Giter Club home page Giter Club logo

Comments (4)

groverlalit avatar groverlalit commented on July 26, 2024

In v3.3.1, we removed the TGW Service-Linked Role (SLR) from the spoke stack to avoid the CloudFormation error shared above. The reason the AWSServiceRoleForVPCTransitGateway can't be deleted because there is an existing TGW attachment. This is by design to avoid issues with TGW attachment creation workflow.

The CloudFormation stack will attempt to delete the SLR resource 3 times and give up. The update stack will complete.
You can ignore the "Deletion Failed" error in IAM console. In this scenario, you don't need to deploy network-orchestration-spoke-service-linked-roles.template as the SLR already exists.

See screenshot below with results.
screenshot-update-spoke-stno-1

from network-orchestration-for-aws-transit-gateway.

jwiechmann avatar jwiechmann commented on July 26, 2024

Hi Lalit,
Thank you for your quick response.
The "Delete failed" error in the IAM console is making it difficult for us to roll out the new spoke template to all of our existing accounts in the organization via StackSet.
Can we use the Spoke template version v3.3.0 instead? Because we don't use the multi-region deployments. Or can you provide a boolean parameter for that?
BTW the old option CreateServiceRoleForVPCTransitGateway did it exactly: Skip or Create!
BR Jens

from network-orchestration-for-aws-transit-gateway.

groverlalit avatar groverlalit commented on July 26, 2024

The update stackSet for spoke stack should complete as the stack will continue to reach "UPDATE_COMPLETE". The new spoke SLR stack can be deployed using higher fault tolerance. Alos, note that TGW SLR can also be created automatically by VPC during attachment creation but only in new accounts (with no existing TGW SLR).

I would not recommend using v3.3.0 as it will impact your upgrade path for future releases.

The option to CreateServiceRoleForVPCTransitGateway CFN parameter worked for your use case but it was not a viable option for multi-region deployments.

from network-orchestration-for-aws-transit-gateway.

groverlalit avatar groverlalit commented on July 26, 2024

Closing this issue in to no activity for over a month. Please reopen this issue if needed. Thanks

from network-orchestration-for-aws-transit-gateway.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.