aws-samples / designing-cloud-native-microservices-on-aws Goto Github PK

File: https://github.com/aws-samples/designing-cloud-native-microservices-on-aws/blob/master/deployment/coffeeshop-cdk/package.json

package.json uses @aws-cdk/assert, which is no longer being actively maintained. Recommend using @aws-cdk/assertion library as recommended by AWS CDK.

Initial deployment via cdk deploy will fail. ROOT CAUSE: aws:policy/AWSLambdaFullAccess managed policy has since been depreciated, resulting in Policy arn:aws:iam::aws:policy/AWSLambdaFullAccess does not exist or is not attachable. (Service:

AmazonIdentityManagement; Status Code: 404; Error Code: NoSuchEntity error message by CDK.

FIX: change the role to the new AWSLambda_FullAccess managed policy, deployment then succeeds.

Run Test - updating curl command to point to my deployed API endpoint, execution fails with 502 Bad Gateway status.

curl --header "Content-Type: application/json" --request POST --data '{"items":[{"productId":"5678","qty":2,"price":200}]}' http://Coffe-AlbSv-S03YRO6K0UPD-1527471424.ap-southeast-2.elb.amazonaws.com/order

The ALB load balancer deployed is failing health status, draining connections as target deregistration is in progress.
On inspecting CloudWatch Logs, Java NullPointerException is reported in the handler code

java.lang.NullPointerException: java.lang.NullPointerException
java.lang.NullPointerException
  at solid.humank.coffeeshop.cofee.sls.orders.OrderCreatedHandler.handleRequest(OrderCreatedHandler.java:46)
  at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
  at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
  at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
  at java.base/java.lang.reflect.Method.invoke(Unknown Source)

Followed the steps in docs/05-deploy-applications-by-cdk/README.md but the Maven build for orders-web failed with:
Exception in thread "main" java.util.ServiceConfigurationError: org.eclipse.microprofile.config.spi.ConfigSourceProvider: Provider io.quarkus.runtime.configuration.TemporaryConfigSourceProvider not found

File: https://github.com/aws-samples/designing-cloud-native-microservices-on-aws/tree/master/docs/04-modeling-and-development

AWS icons used in graphics are not current branding (old icons).

Outputs generated by CDK for imagedefinitions.json file references the incorrect repository name.

Outputs generated by CDK for CoffeeShopCodePipeline.CodeCommitRepoName = EventStormingWorkshop reference the wrong repository name.

All files make reference to an EventStormingWorkshop repository name, rather than its current designing-cloud-native-microservices-on-aws repository name. A potential confusion for readers.

• Deploy Instruction mentions changing github owner but repo also needs changing from EventStormingWorkshop to designing-cloud-native-microservices-on-aws.
• Create build project screenshot UI has since changed
• Connect with GitHub screenshot shows old repository name and old AWS CodeBuild icon branding.

FIX:

This step uses AWS CLI to reference an coffee-sls-OrderCreatedHandler function that has not been deployed previously, and obviously fails.

Instructions do not clearly mention the need for the user to commit changes and git push -u origin master is required. This then triggers the CodeBuild project, thereby deploying the Lambda function. This could be an error prone step for many users.

CodeBuild build will fail during POST_BUILD stage, with below output:

[Container] 2021/09/27 05:16:41 Running command sam deploy --template-file ./packaged.yaml --stack-name coffee-sls --capabilities CAPABILITY_IAM

    Deploying with following values
    ===============================
    Stack name                 : coffee-sls
    Region                     : None
    Confirm changeset          : False
    Deployment s3 bucket       : None
    Capabilities               : ["CAPABILITY_IAM"]
    Parameter overrides        : {}

Initiating deployment
=====================
AcceptOrderFunction may not have authorization defined.

Waiting for changeset to be created..
Error: Failed to create changeset for the stack: coffee-sls, ex: Waiter ChangeSetCreateComplete failed: Waiter encountered a terminal failure state Status: FAILED. Reason: Template error: instance of Fn::GetAtt references undefined resource AcceptOrder

[Container] 2021/09/27 05:16:48 Command did not exit successfully sam deploy --template-file ./packaged.yaml --stack-name coffee-sls --capabilities CAPABILITY_IAM exit status 1
[Container] 2021/09/27 05:16:48 Phase complete: POST_BUILD State: FAILED
[Container] 2021/09/27 05:16:48 Phase context status code: COMMAND_EXECUTION_ERROR Message: Error while executing command: sam deploy --template-file ./packaged.yaml --stack-name coffee-sls --capabilities CAPABILITY_IAM. Reason: exit status 1

Due to this repo was created in 2018, so the default branch name is master. Suggest to migrate to branch main for mainline instead.