Giter Club home page Giter Club logo

Comments (8)

jaykay12 avatar jaykay12 commented on June 25, 2024 1

@sotayamashita Its totally cool man!
But yeah, #116 was closed as it was containing books that were published around 5-7 years, so will it be nice if I add a Book section in the Awesome CSS with 1 or 2 popular books only & later on substantial additions to it can be done by other contributors as well. 😄

@Rishabh04-02 what do you say?

from awesome-css.

troxler avatar troxler commented on June 25, 2024 1

Sorry if my comments in the pull request seem harsh.

I'm not sure whether it is better to require two approvals as it also means double the work. In my opinion it is enough to ping other contributors to comment if a pull request is controversial. If a request is closed or merged, you can always step into the discussion (and reopen the request) if you disagree.


so will it be nice if I add a Book section in the Awesome CSS with 1 or 2 popular books only

@jaykay12 sure.

from awesome-css.

jaykay12 avatar jaykay12 commented on June 25, 2024

@Rishabh04-02 Wasn't my PR Fair enough to serve the purpose? Later on, with course of time enhancements could have been done 😞

from awesome-css.

Rishabh04-02 avatar Rishabh04-02 commented on June 25, 2024

@jaykay12 I've requested the maintainers that we need a discussions platform, once they respond to it then we can have a discussions there regarding the issues, queries and the development of awesome-css.

from awesome-css.

sotayamashita avatar sotayamashita commented on June 25, 2024

@jaykay12 We are sorry to feel bad. Recently I have invited members but I do not have rules.

@Rishabh04-02 What about to create rules for maintainers and first rules will be "We need 2 people approval when we merge PRs" What do you think?

from awesome-css.

Rishabh04-02 avatar Rishabh04-02 commented on June 25, 2024

@sotayamashita This 2 people rule is good 👍 , i agree with it.

from awesome-css.

stale avatar stale commented on June 25, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from awesome-css.

stale avatar stale commented on June 25, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from awesome-css.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.