awenger / coroutinesobfuscationcrash Goto Github PK

Android Sample app that demonstrate how proguard can break kotlin coroutines

kotlin version 1.3.40
coroutines version 1.2.1
android build tool version 3.3.2
reported here: Kotlin/kotlinx.coroutines#1288

Setup:

coroutinesobfuscationcrash/app/src/main/java/com/github/awenger/coroutinesobfuscationcrash/MainActivity.kt

Lines 37 to 55 in bdb0df1

 private suspend fun call() = try { 

 coroutineScope { 

 val result1 = async { retrieve() } 

 val result2 = async { retrieve() } 

 listOf(result1, result2).awaitAll() 

 Log.d(LOG_TAG, "all successful retrieved") 

 true 

 } 

 } catch (ex: IOException) { 

 Log.e(LOG_TAG, "caught ${ex.message}") 

 false 

 } 

 @Throws(IOException::class) 

 private suspend fun retrieve() { 

 delay(100) 

 Log.d(LOG_TAG, "waited for 100ms, throwing IOException") 

 throw IOException("could not contact server") 

 }

suspend function retrieve in line 50-55 throws an exception suspend function call in line 37-48 calls the previous function via async{ retrieve() }....await() and should catch the exception

Without proguard minification (minifyEnabled false) the exception is handled properly:

D/Main: waited for 100ms, throwing IOException
E/Main: caught could not contact server
D/Main: success: false

With proguard minification (minifyEnabled true) the exceptions just disappear and the outcome of the program changes to:

D/Main: waited for 100ms, throwing IOException
D/Main: waited for 100ms, throwing IOException
D/Main: all successful retrieved
D/Main: success: true

Just change the minifyEnabled property here and the behavior should change:

coroutinesobfuscationcrash/app/build.gradle

Line 19 in bdb0df1

 minifyEnabled false // set this to true and it will change the output to success: true 

awenger / coroutinesobfuscationcrash Goto Github PK

coroutinesobfuscationcrash's Introduction

Android Sample app that demonstrate how proguard can break kotlin coroutines

Setup:

coroutinesobfuscationcrash's People

Contributors

Watchers

Forkers

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	private suspend fun call() = try {
	coroutineScope {
	val result1 = async { retrieve() }
	val result2 = async { retrieve() }
	listOf(result1, result2).awaitAll()
	Log.d(LOG_TAG, "all successful retrieved")
	true
	}
	} catch (ex: IOException) {
	Log.e(LOG_TAG, "caught ${ex.message}")
	false
	}

	@Throws(IOException::class)
	private suspend fun retrieve() {
	delay(100)
	Log.d(LOG_TAG, "waited for 100ms, throwing IOException")
	throw IOException("could not contact server")
	}