awegroup / megawes Goto Github PK

I was trying to implement a circular or elliptical path in MegAWES and trying my chance by changing lemniscate parameters such as a_booth and b_booth to different values, but nothing changed in the first traction phase, and the flight got unstable at the early steps of the first retraction phase.
I thought that the lemniscate parameters determine the reference trajectory on the unit sphere, and changing those parameters leads to a new maneuver similar to the reference trajectory on the unit sphere. So, Would you please guide me on why the first traction phase is independent of lemniscate parameters and how I can implement a circular or elliptical path in the MegAWES?

This is a very nice simulation framework!

But using a closed source language like Matlab/Simulink for an open source project is not a good choice.
Only academics in rich western countries can use it.

So I suggest to port this code to Julia (see: https://julialang.org/ )

Example for a generic flight simulation framework in Julia: https://github.com/JinraeKim/FlightSims.jl

Example for a kite power system model in Julia: https://github.com/ufechner7/KiteViewer/tree/sim/src

Porting Matlab to Julia should be easy, porting Simulink to Julia is more involved. But Julia has differential equation solvers that are orders of magnitude faster and more stable than Simulink.

Hi,

In Dyn_6DoF_v2_0_r2019b/AirborneSystem/FlightControlSystem/AttitudeAndRateLoop/RateLoop/ControlAllocation/allocation the control effectiveness matrix Ba is calculated based on the DE2019 model. When executing the following code (after having loaded the DE2019 aircraft model and having initialized the sim):

alpha = 0.1;
Cl_deltaA =DE2019.Cl_deltaA_0 + DE2019.Cl_deltaA_alpha * alpha + DE2019.Cl_deltaA_alpha2 * alpha^2;
Cl_deltaR =DE2019.Cl_deltaR_0 + DE2019.Cl_deltaR_alpha * alpha + DE2019.Cl_deltaR_alpha2 * alpha^2;                                 
 
Cm_deltaA =DE2019.Cm_deltaA_0 + DE2019.Cm_deltaA_alpha * alpha + DE2019.Cm_deltaA_alpha2 * alpha^2;  
Cm_deltaE = DE2019.Cm_deltaE_0  + DE2019.Cm_deltaE_alpha * alpha + DE2019.Cm_deltaE_alpha2 * alpha^2; 
 
Cn_deltaA =DE2019.Cn_deltaA_0 + DE2019.Cn_deltaA_alpha * alpha + DE2019.Cn_deltaA_alpha2 * alpha^2;  
Cn_deltaR =DE2019.Cn_deltaR_0 + DE2019.Cn_deltaR_alpha * alpha + DE2019.Cn_deltaR_alpha2 * alpha^2;
 
Ba = [[Cl_deltaA,0,Cl_deltaR];[Cm_deltaA,Cm_deltaE,0];[Cn_deltaA,0,Cn_deltaR]]

You get:

Ba =
0.1474             0    0.0090
0.0142   -1.8535            0
         0             0    0.0759

This is unexpected from what I generally know about aircraft control because Cm_deltaA is nonzero and Cn_deltaA is zero. This is strange because you would expect that an asymmetric aileron deflection does not have an effect on the pitch moment (so Cm_deltaA = 0) and that it does have an effect on the yaw moment (so Cm_deltaA != 0). Maybe the m and n subscripts got mixed up somewhere? Or this is correct and just different from what I would expect (very possible)?

I dug a little bit further into it and the fits that are done in Src\Common\initAllSimParams_DE2019.m seem correct so the data it uses might be false. In that case, B_Axx are not correct which are loaded from Lib\6DoF\Control_allocation_V60.mat.

Essential

• Document verification of user installation
• Document how users can verify the proper functioning of the software

Recommended

• Defensive programming
• Test your software with integration tests and unit tests
• Make use of Continuous Integration
• Code coverage check (Codecov, Sonarcloud, Travis)

Remarks

• MATLAB has a toolbox available for Simulink testing.
• Matlab offers examples of setting up GitHub Actions for MATLAB

Essential

• Obtain a DOI from (Zenodo or 4TU.ResearchData)

Recommended

• Semantic versioning
• Tagged releases (GitHub)
• CHANGELOG
• Upload to registry (PyPI, conda, DockerHub)
• Release guide
• Continuous Integration for build and release

Remarks

• It was mentioned that the software was archived, but no link is available

I am trying to run the code on Matlab R2022a. I get the following error when running Run_OneSimulation.m:

Error using load
Unable to read MAT-file /home/ufechner/repos/MegAWES/Lib/Common/DE2019_params.mat. Not a binary MAT-file. Try load -ASCII to read as text.

Error in initAllSimParams_DE2019 (line 47)
load('DE2019_params.mat','DE2019','constraintOut');

Error in Get_simulation_params (line 90)
            initAllSimParams_DE2019(Kite_DOF);

Error in Run_OneSimulation (line 40)
	Get_simulation_params(windspeed, Kite_DOF);

Any idea?

Dependency management

Essential

• Document your project dependencies
• Provide instructions for replicating the computational environment

Recommended

• Use a dependency manager
• Pin exact versions used to generate your environment

Optional

• Containerized workflow

Remarks

• We have identified that the simulation does not converge when using MATLAB 2023b in #7
• MATLAB does not have a dependency manager

Hello rschmehl,
When i try to run the simulation, iget the following error:
Error using load
Unable to read MAT-file C:\Users\lumas\Downloads\MegAWES.git\tags\2.0\Lib\Common\DE2019_params.mat. Not a binary MAT-file. Try
load -ASCII to read as text.

Is it because of me running a newer matlab version(2020b)?
Yours sincerely LMSchaefer

Version control

Essential

• Use git as a version control system
• Upload your project on GitHub or TU Delft GitLab

Recommended

• Make your repository public
• Branch hygiene
• Meaningful commit messages

Remarks

• Branch management is currently not implemented. Depending on the complexity of the project, the DCC recommends either using GitHub Flow or GitFlow for branch management.
• Most of the commits are on changing documentation and metadata. Commits that contribute to the source code provide limited information.

Essential

• Installation instructions
• User documentation
• Developer documentation
• Source code documentation (docstrings)

Recommended

• Examples and tutorials (Jupyter notebooks, videos, screencasts)
• Automate documentation building with sphinx
• Website (github.io pages, Readthedocs, JupyterBook)

Optional

• Build API reference from docstrings

Is your feature request related to a problem? Please describe.
Users might encounter issues during installation, which are hard to decipher what went wrong.

Describe the solution you'd like
Add functions to check:

• Git-lfs files non-empty
• Installed add-ons
• Check current working directory

Project documentation

Essential

• README
• LICENSE
• CITATION

Recommended

• Make use of Github issues
• Code of conduct

Essential

• Project organisation
• Record software dependencies

Recommended

• Follow a consistent code style, such as PEP8 guidelines
• Use a linter (pylint, flake8)
• Use a formatter (black, yapf)
• Follow best coding practices

Remarks

• MATLAB does not offer a default code style, but third-party guidelines has been shared
• MATLAB has a Dependency analyzer available
• MATLAB's internal linter is called mlint

Reviewer: @mwakok
Date: 13 Feb 2024
Version: commit c559e7f

Test 1

Steps

1. Pre-installed MATLAB R2023b available on system
2. Install git lfs
3. Install required Addons through TU Delft license
4. Run_OneSimulation.m runs without error
5. No status updates during execution
6. Creates folder Cache_temp

Output

• Total elapsed walltime is: 61.9 seconds
• Warning: Simulation did not converge
• Returns no plots or animation
• Leaves workspace occupied with various variables

Test 2

Repeated on different system with MATLAB 2020b

Output

• Created figure 1: Continuous power
  

• Created figure 2: Flight path, power coloured
  

• Total elapsed walltime is: 89.6649 seconds

• Output to terminal:

  CL @ CDeff: 1.73 
  CDeff: 0.24022 
  Tether length: 804.6032 
  Peak power (reel-out): 8.4718 MW 
  Power density: 6521.9 
  Costello Pavg max. (reel-out): 5.8341 MW 
  zeta: 11.5577 
  

Is your feature request related to a problem? Please describe.
Readthedocs does not have access to the matlab engine, making it impossible to create screenshots of the simulink models.

Describe the solution you'd like
A docker with python and access to the matlab engine with simulink.

Describe alternatives you've considered
Run sphynx offline with the right packages to create the images and then readthedocs uses thos images instead.
This required an edit to the package available by pip, so this edited package needs to be available as a whl file by readthedocs.

Essential

• Make use of Github issues
• Provide contribution guidelines

Recommended

• Choose a branching model (DCC Guides on branches)
• Make use of issue templates
• Provide a Code of Conduct
• Use semantic versioning for your releases