avnet / ap1302-driver Goto Github PK

The stereo camera positioning has changed with release 428. Update driver accordingly.

0102bb8#commitcomment-84924231

The 3d_path bit has been removed starting with release 428. Instead the "left" sensor is the one selected with sensor_select.sensor field (bits [1:0]):

sensor_select.sensor = 0: test pattern (2x if mode_3d_on is set)
sensor_select.sensor = 1: primary sensor (if mode_3d_on is set then primary is on the left and secondary on the right)
sensor_select.sensor = 2: secondary sensor (if mode_3d_on set then secondary is on the left and primary on the right)

• look at resolution, ex: ar0144 @ Full HD, where is the upscale done ?
• could read the resolution from the firmware

OnSemi looking at the sensor detection process for SIP value.
May use the number of lanes as a indicator for driver write, may not be needed if sip value only useful after firmware load ( aka stereo mode ).

Tested secondary sensor only : issue is that hardware uses primary sensor clock and reset for both modules thus, update the driver to enable all clock and reset when secondary is enabled.
If present, secondary clock and reset would be GPIO2, GPIO3 ( not support by NXP ).
Sensor Select, add a device tree property for the secondary sensor to use primary sensor clock and reset.

With new firmware 429 and newer, header could be optional since CRC and pll_init_size are not used.

stehla@2e60df7#diff-2bb8fb9bfa2989b7871467dfd31e24f8728c7b5456b8140327ed45ed6a90286eR3084

	if (fw_hdr->magic != FW_MAGIC) {
		fw_data = (u8 *)fw_hdr;
		fw_size = ap1302->fw->size;
	} else {
		fw_data = (u8 *)&fw_hdr[1];
		fw_size = ap1302->fw->size - sizeof(*fw_hdr);
	}