autresphere / asdepthmodal Goto Github PK

I am seeing mainViewController while showing up from a viewController that is presented over already presented viewController.

Hi,
I encountered an issue when trying to implement this in my app.
The background view is the root view controller not the viewcontroller from where I started the action, and when I close the popup it redirects to the root view controller of the application.
Can you help?

It gonna get an error with

• (IBAction)myButton:(id)sender {

  NSLog(@"Pressed");

}

Hi,

I copied in my own fork a set of animations from https://github.com/Sumi-Interactive/SIAlertView to this controller.

Should i submit a pull request?

You can check it here:
https://github.com/jonasman/ASDepthModal

Xcode 4.6, ARC

When using Xcode's analyze function, following part shows dead store and memory error.

//perform convolution
error = vImageBoxConvolve_ARGB8888(&inBuffer, &outBuffer2, NULL, 0, 0, boxSize, boxSize, NULL, kvImageEdgeExtend);
error = vImageBoxConvolve_ARGB8888(&outBuffer2, &inBuffer, NULL, 0, 0, boxSize, boxSize, NULL, kvImageEdgeExtend);

Hello,

When the line is exected:
window.rootViewController = self;

The actual RootView Controller recevies a message : viewWillAppear and viewDid appear because it was changed to an ASDepthModal view. ( [self.view addSubview:self.rootViewController.view];)

I think this is not good behaviour. And what about changing the implementation to add the modal view not to the root but as a presenting VC of the current VC or of the current root?

Since ASDepthModal changes the rootViewController of the navigationController, we need some type of call back after calling "dismiss" to let us know when the original rootViewController is restored.

In iOS 7:

View Controller a.hidesBottomBarWhenPushed = YES;

So the tar bar is hidden when a is pushed.

But the tar bar is shown when aPopupView dismiss:

[ASDepthModalViewController presentView:aPopupView];

It would be good to know when the popup has disappeared.
A completionBlock could be passed to the dismiss and it would be called after the popup had been dismissed.

What do you think?

It's not working on iOS5 :(

Hi, great modal component, maybe you can add to the readme file that you need to import the following frameworks to make it work.

QuartzCore.framework
Accelerate.framework

This feature Tap outside to close could be optional via use of a property.

What do you think?

I have a UIAlertView showing, then popover ASDepthModal view. After I dismiss ASDepthModal view. the app will be dead (can not response to any touch event)

This happens on iOS7, seems that in iOS7 UIAlertView hierarchy in window has changed.

There is a leak in -(UIImage *)boxblurImageWithBlur:(CGFloat)blur.
The pixelBuffer2 is never released. Each time you call presentView: from ASDepthModalViewController the sample application consumes 3MB of memory.
I know this function is borrowed from https://github.com/rnystrom/RNBlurModalView/blob/master/RNBlurModalView.m but in the original code there is additional line(#700) in the cleanup section "free(pixelBuffer2)" - this will fix the issue.

Memory consumption at the begining:

Memory consumption after firing ASDepthModal several times:

Hi,

I use ASDepthModal as a detail view for images. The images within the rootViewController have a alpha of 0.5 unselected. If I start ASDepthModal with a few selected images - the alpha is changing to 1 - in the second where the modal starts. And it stays.

Issue title

Please add semantic version tags.

Issue description

I’ve recently added ASDepthModal to the CocoaPods package manager repo.

CocoaPods is a tool for managing dependencies for OS X and iOS Xcode projects and provides a central repository for iOS/OS X libraries. This makes adding libraries to a project and updating them extremely easy and it will help users to resolve dependencies of the libraries they use.

However, ASDepthModal doesn't have any version tags. I’ve added the current HEAD as version 0.0.1, but a version tag will make dependency resolution much easier.

Semantic version tags (instead of plain commit hashes/revisions) allow for resolution of cross-dependencies.

In case you didn’t know this yet; you can tag the current HEAD as, for instance, version 1.0.0, like so:

$ git tag -a 1.0.0 -m "Tag release 1.0.0"
$ git push --tags