automattic / s3-media-sync Goto Github PK

We noticed that UpdraftPlus is unable to connect to AWS when this plugin is active. It turns out UpdrafPlus also bundles the AWS PHP SDK, but requires a much older version of the package. In order to prevent conflicts like this it would be helpful to namespace the dependencies.

It would be great if we can add another subcommand to upload a single attachment only, like

wp s3-media upload <attachment_id>

The benefit would be that, based on a known list of attachment IDs that we need to upload, we could combine WP_CLI with xargs to upload each attachment using parallel threads giving us much more refined control on the execution of the upload process.

As an alternative to S3 it would be great if we could allow additional endpoints. Human Made does this with the s3_uploads_s3_client_params filter](https://github.com/humanmade/S3-Uploads/blob/master/inc/class-s3-uploads.php#L272) which I think we can add here:
https://github.com/Automattic/s3-media-sync/blob/master/inc/class-s3-media-sync.php#L302

Let me know if this makes sense, then all one has to do to change the endpoint is:

// Filter S3 Uploads params.
add_filter( 's3_uploads_s3_client_params', function ( $params ) {
	$params['endpoint'] = 'https://your.endpoint.com';
	$params['use_path_style_endpoint'] = true;
	$params['debug'] = false; // Set to true if uploads are failing.
	return $params;
} );

After editing an image in the WordPress admin, the image is not copied to the S3 bucket.