Auto-impl trait objects? about auto_impl HOT 8 CLOSED

This might work best as an independent 'flag' somewhere in the attribute, since if you specify #[auto_impl(&, Box)] you probably want both to be implemented for dyn Trait. Maybe even just something like:

#[auto_impl(dyn, Box, &, &mut)]
pub trait Trait {}

So you don't have different items to bring into scope. It's a bit of a semantic overloading of what goes in the attribute, but I think it's a simple enough concept that it shouldn't be an issue. What do you think? I'm guessing any support is going to be welcomed 😄

from auto_impl.

@daniel5151 As you can see from this thread, there are a few open questions (mainly regarding how to specify this). To be honest, I don't use auto_impl anymore and have kind of lost interest in the project, so I will not implement this. If you want to see this, you probably have to implement it yourself :/ (and even then, no guarantees how quickly I can review the PR)

from auto_impl.

FYI trait-objects are supported by impl-tools (see tests) for examples).

from auto_impl.

I think this would be a useful addition to the library. However, won't have time to implement this any time soon.

Also, there are some open questions, in particular how to specify those types in the #[auto_impl(...)] attribute. Maybe we should support #[auto_impl(Box<dyn>)] (trait object) and #[auto_impl(Box<impl>)] (the current behavior, static dispatc). And #[auto_impl(Box)] would just add both impl blocks? Just some quick ideas. I'd love to find a brief, easy to read and general syntax to specify impl blocks that auto-impl should generate. Ideas welcome!

from auto_impl.

I think Box<dyn> looks OK, and the previous ones can stay as they were.

Alternatively:

• #[auto_impl(Box)] does both #[ auto_impl_dyn(Box)] and #[auto_impl_stat(Box)] do one or the other

from auto_impl.

I'd also love to see this added. It would let me remove this gnarly macro from my project 😄

Aside from Box<dyn T>, there's also &dyn T and &mut dyn T as well.

I would recommend keeping the two impls separate, as not all Traits can be used as Trait Objects (see Object Safety).

from auto_impl.

Seeing as #72 was just resolved, this is the only other issue that's blocking me from using auto_impl in my project.

Any updates on if/when this could get implemented?

from auto_impl.

This is probably something best left to impl-tools to handle. This library is quite tightly focused on a single simple use-case, so I've opened #79 to point users to it if they need something more sophisticated.

from auto_impl.