I found this project which could help

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

syn-mid doesn't seem to offer <code class="notranslat

Hi <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="

Investigate using `syn-mid` about auto_impl HOT 3 CLOSED

LukasKalbertodt commented on July 20, 2024

Investigate using `syn-mid`

from auto_impl.

Comments (3)

LukasKalbertodt commented on July 20, 2024 1

@taiki-e Thanks for checking out this issue and taking the time to have a look at this code! It's really appreciated.

The code you linked... could probably work fine without the Visit feature of syn, but would be more verbose. I guess we won't use syn-mid in auto-impl anytime soon then. We can revisit this issue if anything significant changes :)

Thanks again!

from auto_impl.

LukasKalbertodt commented on July 20, 2024

syn-mid doesn't seem to offer ItemTrait and related types. So it seems like we can't use it here.

@taiki-e: Hello there! Is there a reason why syn-mid does not offer ItemTrait? Or am I missing something? Do you think this project (auto_impl) could use syn-mid? We need to parse trait definitions, but we do not care about function bodies.

from auto_impl.

taiki-e commented on July 20, 2024

Hi @LukasKalbertodt. The types provided by syn-mid are not compatible with visit feature, so even if syn-mid provides ItemTrait, I think it is difficult to use syn-mid in auto_impl .

For example, the following visitor seems to be visiting the signature of a function, but as syn::Signature needs full feature, the same cannot be done with syn-mid.

auto_impl/src/analyze.rs

Lines 46 to 62 in f5d3f9b

 impl<'ast> Visit<'ast> for IdentCollector<'ast> { 

 fn visit_ident(&mut self, i: &'ast Ident) { 

 self.ty_names.insert(i); 

 } 

 // We overwrite this to make sure to put lifetime names into 

 // `lt_names`. We also don't recurse, so `visit_ident` won't be called 

 // for lifetime names. 

 fn visit_lifetime(&mut self, lt: &'ast Lifetime) { 

 self.lt_names.insert(&lt.ident); 

 } 

 // Visiting a block just does nothing. It is the default body of a method 

 // in the trait. But since that block won't be in the impl block, we can 

 // just ignore it. 

 fn visit_block(&mut self, _: &'ast Block) {} 

 }

from auto_impl.

Recommend Projects

Investigate using `syn-mid` about auto_impl HOT 3 CLOSED

Comments (3)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	impl<'ast> Visit<'ast> for IdentCollector<'ast> {
	fn visit_ident(&mut self, i: &'ast Ident) {
	self.ty_names.insert(i);
	}

	// We overwrite this to make sure to put lifetime names into
	// `lt_names`. We also don't recurse, so `visit_ident` won't be called
	// for lifetime names.
	fn visit_lifetime(&mut self, lt: &'ast Lifetime) {
	self.lt_names.insert(&lt.ident);
	}

	// Visiting a block just does nothing. It is the default body of a method
	// in the trait. But since that block won't be in the impl block, we can
	// just ignore it.
	fn visit_block(&mut self, _: &'ast Block) {}
	}