Comments (4)
Mordred
commented on May 18, 2024
Can you release this?
from dialog.
plwalters
commented on May 18, 2024
@Mordred I saw an issue on the dialog and realized this commit broke the styling on the modal. It is now 100% width of the screen. Are you sure that the PR was working properly? I'm going to have to back it out I think. You can see the issue by cloning the repository and running the sample app with gulp watch
from dialog.
Mordred
commented on May 18, 2024
@PWKad Can you post some images? Because I don't know what you mean. I've tried your sample it using Chrome and modal has only 300px. What browser are you using?
from dialog.
plwalters
commented on May 18, 2024
Sorry I think the issue was the Chrome styling for a native dialog element caused the math introduced in this PR to work but when I switched the name it went crazy. Sorry for the false alarm.
from dialog.
Related Issues (20)
- Dialog VM hooks for keyboard (Enter/Escape) HOT 7
- Add class reference support for .viewModel HOT 4
- Plugin setting configurations not working HOT 1
- Error when building HOT 1
- AttachFocus is not the default export
- Bug: Lazy loading components causes unnecessary webpack chunks HOT 14
- Dialog does not open when webpack bundle is built in production mode HOT 7
- Remove .rollupcache folder from npm package
- Cannot find name 'AddEventListenerOptions'. HOT 7
- Global callbacks / events every time a dialog opens / closes HOT 8
- Focus management on open / close HOT 5
- Typings fail to install HOT 1
- typings.json does not define dependency versions HOT 2
- DialogCloseError is not exposed in typings HOT 2
- Add whenConfirmed alongside whenClosed HOT 1
- Doesn't load template page in IE11 HOT 12
- null reference error on closing dialog
- Support typing the model with a generic type argument on the open method HOT 2
- dialog forces mulptiple chunks in webpack prod build HOT 1
- 404 on typings install for Aurelia metadata HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dialog.