Add class reference support for .viewModel about dialog HOT 4 CLOSED

I think it's fine to have the dialog api know nothing about promises or factories. So, if lazy loading is needed, the developer would use import('some/path').then(m => this.dialogService.open({viewModel: m.MyDialogVM})). I think router is a bit different in that it does need to have registrations up front, but evaluation later. Modals are usually invoked directly and at the exact time they are needed.

from dialog.

The router needs it lazy since it stores the VM factories for later optional/uncertain usage.

For this, I think we can also say they are both for later optional / uncertain usage. Typically the code responsible for opening dialog will be inside a class method, which makes it

from dialog.

@bigopon what you are saying is that the execution of the code(user code) that is using those APIs is uncertain and for that was my example import().then(m => this.dialogService.open({viewModel: m.MyDialogVM})). This does not change the fact that when you call the dialog API the class will be used.

from dialog.

Keeping the current API.
Change already merged.

from dialog.