augustmiller / kirby-place-field Goto Github PK

This appears to be affecting some installations, already, despite the October cutoff.

It may be a good time to move to the new plugin/registration API in Kirby, to split apart services, like geocoding.

In any case, configuration should happen in the global space:

c::set('place.keys.server', 'PRIVATE-KEY');
c::set('place.keys.browser', 'PUBLIC-KEY');

This backtrace is woefully incomplete… What produces this error?

Presumably one of the places that we're injecting content into a field (which then needs to be converted to a string for HTML output), via the Brick and html classes…

Updates can be made to the "Address" field without being serialized.

Currently, the store() method is only called after attempting to geocode the input. We should always store the value, even if the map hasn't been changed, because users may search, reposition the pin, then rename the location.

So I'm using the place field and it works almost perfectly. The only issue I have is that I haven't been able to set the default zoom despite following the README's example almost to the letter:

fields:
   address:
      label: Address
      type: place
      center:
         lat: 45.5230622
         lng: -122.67648159999999
         zoom: 13
      help: >
         Look up an address or location.

So if the issue isn't stemming from the blueprint file any ideas what might be causing the issue? or even better: how to go about fixing it? Thanks for the dope little Kirby extension.

The Sass files are here, but a compiled CSS file should probably be included, so that end-users can just download and install, without worrying about compilation of stylesheets.

There doesn't appear to be a native/standard implementation for localizing plugins, but it shouldn't stop the plugin from being usable in all locales.

Why is the location data stored in JSON over markdown in the markdown files?

Can't we keep the data clean and readable in the markdown format - some people edits the content through dropbox.

Hey, thanks for your work on this plugin. I'm trying to squeeze the zoom into the data that gets serialized to the content-file, but i can't get it to work.

These are the fields I'm currently writing to the returned field object:

store: function () {
      //this.map_canvas = this.container.find('.field-google-map-ui');
      this.field.val(JSON.stringify({
        address: this.location_fields.address.val(),
        lat: parseFloat(this.location_fields.lat.val()),
        lng: parseFloat(this.location_fields.lng.val()),
        zoom: parseFloat(this.map.getZoom())
      }));
    }

When i call this.map.getZoom() it always returns 9, regardless of the actual zoom. Is there a function that gets executed before store function that is somehow resetting the map zoom? The 9 seems to originate from this data-zoom attribute.