audun / factorio-closestfirst Goto Github PK

I connected to my server running closest first and under mod settings - Map wide settings I changed 'Max range' to 'unlimited (up to equipped port range)'. The server crashed on saving the settings, i assume in the first tick of the mod running with the new settings.

As discussed here: https://mods.factorio.com/mod/ClosestFirst/discussion/5e3063fd5a9e76000b48166d

Its pretty simple to make this work with 0.18. Would you please add this?

Thank you so much for the mod, its awesome, kudus! :D

Just some notes on your use of the api: https://github.com/audun/factorio-closestfirst/blob/master/control.lua#L276
You check valid and connected here. That is useless. game.connected_players will only give you connected and valid players.

Unless you have a save from an old mod version where your on_init didnt exist, global.close_entities == nil will never be true.
If there is an older version of the mod where the global doesnt exist, simply create it in on_configuration_changed instead of checking for it everywhere.

When accessing the player inventory or quickbar, I recommend use of LuaControl::get_[main_inventory/quickbar] because it will work for any type of controller instead of just the character controller.

Find entities filtered allows big performance gains over simply getting all entities in an area. You could filter to only find things from the player's force and the neutral force. Yes, I am aware of your modding interface request to make it even more useful for you :)

Hello,

nice idea love it.

Sadly the mod crashes on data stage with:
Error in assignID, item with name 'creative-mode-fix_super-personal-roboport-equipment-reduced-0' does not exist.
if the Creative mod (https://mods.factorio.com/mod/creative-mode-fix) is installed.

Cu, Stephan (BladesAndRazors @ Dicord, if questions arise)