atveit / amplitude-python Goto Github PK

Hi @atveit and thanks so much for your efforts in building this library. I was wondering if you are planning to support the new v2 API anytime soon.

Thanks so much!

When checking if we have a valid user_id like so:

    def _is_None_or_not_str(self,value):
        if value is None or type(value) is not str:
            return True

...we are missing Unicode strings, which are the default in Python 3 and very common earlier. What about this?

    def _is_None_or_not_str(self,value):
        if value is None or not isinstance(value, basestring):
            return True

Would that be reasonable?

even though user_properties is mentioned in the code comment, but when it's passed in as argument it is omitted.

I have a PR that fixes it. #5

This library is very old.
It's uses testtools which uses unittest2 which uses and older version of argparse before it got introduced into python officially (Back when it was only here - https://github.com/bewest/argparse)

Causing this issue:

argparse.ArgumentParser('PROG', allow_abbrev=True)
3.6.8 (default, Aug  2 2019, 17:42:44) 
[GCC 4.8.5 20150623 (Red Hat 4.8.5-28)]
Traceback (most recent call last):
  File "<console>", line 1, in <module>
TypeError: __init__() got an unexpected keyword argument 'allow_abbrev'

If you use this on elastic beanstalk you would encounter an error.

Solution probably to fork it and update the package