atsushieno / resident-midi-keyboard Goto Github PK

It would be nice to have mappings for CC/pitchbend etc. It is also a community feedback.

(taking over #2 as the issue is about different aspect now)

At #2 we're done with basic controllers, but we do not really preserve states for the control parameters per index, etc.

We do have some class in ktmidi (Midi2Machine), but I'm not sure if it gives better experience. Will it work consistently with the keyboard component that sends and/or resets pitch-bend state etc. ? Things are not reactive so far, and if we have to make everything reactive it will be non-trivial changes.

We also have to keep compatibility with MIDI1 (have both states and apply conditionally?)

Currently the "discrete" switch at the rightmost of the knob controller combo is implemented using this code:

Image(imageVector = if (discrete) Icons.Default.CheckCircle else Icons.Default.Close,
        "send", Modifier.size(32.dp))

It is not looking very obvious. But I have no idea what could be better. We cannot hover mouse cursor on mobiles so it must be self-explanatory.

needs investigation (from community report) but I assume it happens by nature as switching new protocol "should" take a while. What we need would be to disable further inputs for a few milliseconds until the protocol change is applied.