Guide shows behind untitled editor on first run about welcome HOT 10 CLOSED

It's just that the guide is focused, correct? Likely because it is opened last.

from welcome.

It's just that the guide is focused, correct?

The editor was focused in this case I believe.

from welcome.

I guess I'm confused. Can you give me exact steps? My assumption:

• open welcome
• it opens welcome in left pane then guide in right pane; at this point the right pane has focus
• cmd+n
• opens new buffer in right pane

from welcome.

Can you give me exact steps?

• Open Atom for the first time
• That screenshot is what I saw

from welcome.

Here is the beginning of the open-initial-empty-buffer code, and here is the handler in the renderer process. The entire way through, this initial buffer opening is implicit via a null path. My thoughts right now are:

• I would like this to be explicit for clarity. It wasnt very easy to follow through main -> app -> window -> IPC.
• I want to get metadata through to the renderer handler indicating that the buffer is or is not the initial empty buffer
• I want to have an event like atom.onWillOpenInitialEmptyBuffer({cancel}) where cancel will allow a package to not open said buffer.

Any opinions on this approach? @kevinsawicki @nathansobo?

from welcome.

I don't have a ton of context on this but it seems reasonable. So to clarify, the issue is that we're opening an initial empty buffer when we want to only show the welcome screen and you're seeking to preempt it?

from welcome.

when we want to only show the welcome screen and you're seeking to preempt it

Yeah

from welcome.

Sounds good.

from welcome.

Any opinions on this approach?

I would like this to be explicit for clarity.

👍 This would be great, this code path is very hard to follow currently and easy to break on the browser process side.

I want to get metadata through to the renderer handler indicating that the buffer is or is not the initial empty buffer

It would be great if we could get this to be 100% a render process concern

I want to have an event like atom.onWillOpenInitialEmptyBuffer({cancel})

I'm down for an API, though I think having the untitled buffer behind the welcome guide is kind of nice, once you digest the welcome information and close it, you got a buffer ready to go.

from welcome.

I think having the untitled buffer behind the welcome guide is kind of nice, once you digest the welcome information and close it, you got a buffer ready to go.

The only way to do that today without changing browser code is to add the welcome panes on a long timeout (> 500ms).

Check out the PR at atom/atom#5812. I think it would be useful to pass some information indicating whether it's opening the initial buffer. It has upsides elsewhere too: This person could disable it in their init script, we could make an option for it, etc.

from welcome.