atom-archive / emissary Goto Github PK

Is there some specific reason why it needs EXACTLY that commit?

This is a big deal because this method is used all over the place in our model. This is caused by using an args... formal parameter. This issue is tracking the problem in CoffeeScript.

@benogle: I remember you mentioning seeing emit as a huge part of the profile in find and replace. This seems like it could be a big part of the reason why.

While editing in Atom I get an error, "Uncaught RangeError: Maximum call stack size exceeded" every once in a while that pops up the console.

It says it's coming from /Applications/Atom.app/Contents/Resources/app/node_modules/emissary/lib/behavior.js:1 but I suspect that doesn't really tell you much.

Anything I can do to help pin this down? It's been happening for several weeks a couple of times per day. It's usually triggered when I click on a line of code to move the cursor.

It'll be really nice if emissary could work without the option --harmony, so that we can use node-pathwatcher with the normal node configuration.

There is a simple way of doing it using the harmony-collections module:

• Add harmony-collections to the node dependencies
• Fallback to harmonyCollections.WeakMap if WeakMap is not defined.

I can do a PR for this if you're ok with it.

Having an example implementation to refer to would be useful for new developers.