atkphpframework / atk-community Goto Github PK

Issue by PhrozenByte from 2012-09-03 23:36:49 +0200
Originally opened as https://github.com/atkphpframework/atk-history/issues/7

The MultiUpdateHandler isn't fully implemented yet - nearly everything of validation and checking (as well as permission checks) are missing.

Issue by PhrozenByte from 2014-04-18 04:17:57 +0200
Originally opened as https://github.com/atkphpframework/ATK_7_1_DEV/issues/5
Original title: Rebase to atkphpframework/atk@develop

Your initial code commit (af1f8aeba2) is exactly the same as https://github.com/atkphpframework/atk/tree/develop - apart from dalers doc changes (I've reviewed that with diff). I appreciate new development, but why are you not using the existing repo? This also applies to your ATK_7_0_DEV repo.

Issue by PhrozenByte from 2012-08-23 15:45:30 +0200
Originally opened as https://github.com/atkphpframework/atk-history/issues/6

Storing data grids in session is not a good idea when many grids are displayed within a page - the size of the session explodes. Sessions with > 1 MB aren't unusual when you have 100 grids on a page. The performance impact is crazy, a session of 1 MB results in a additional memory-usage of ~ 10-20 MB (per request!).

Issue by PhrozenByte from 2012-08-03 13:47:25 +0200
Originally opened as https://github.com/atkphpframework/atk-history/issues/5

Currently the grid records of a atkOneToManyRelation are loaded within the display() and edit() methods. It's a kind of funny that $grid->loadRecords() is both times commented as "early loading"... That's not "early" - the contrary is the case. The record loading should be implemented within the regular load() method, the whole grid should be created within the init() method.

syntax error in datetimeattribute.inc
see my pull request for the fix

Issue by Jacob2007 from 2012-07-17 12:32:59 +0200
Originally opened as https://github.com/atkphpframework/atk-history/issues/4

ERRORS when login

Deprecated: Assigning the return value of new by reference is deprecated in C:\xampp\htdocs\atk65\demo\app.php on line 58
Deprecated: Assigning the return value of new by reference is deprecated in C:\xampp\htdocs\atk65\demo\app.php on line 59
Deprecated: Assigning the return value of new by reference is deprecated in C:\xampp\htdocs\atk65\demo\app.php on line 60
Deprecated: Assigning the return value of new by reference is deprecated in C:\xampp\htdocs\atk65\demo\app.php on line 63
Deprecated: Assigning the return value of new by reference is deprecated in C:\xampp\htdocs\atk65\demo\app.php on line 66
Deprecated: Assigning the return value of new by reference is deprecated in C:\xampp\htdocs\atk65\demo\app.php on line 78

SOLUTION:
In PHP5 '&new' is deprecated should be 'new'

IN app.php REPLACE LINES

    $topframe = &new atkFrame($frame_top_height?$frame_top_height:"75", "top", "top.php", FRAME_SCROLL_NO, true);
    $mainframe = &new atkFrame("*", "main", $destination, FRAME_SCROLL_AUTO, true);
    $menuframe = &new atkFrame(($position==MENU_LEFT||$position==MENU_RIGHT?($frame_menu_width?$frame_menu_width:190):$menu->getHeight()), "menu", "menu.php", $scrolling);
    $root = &new atkRootFrameset();
    $outer = &new atkFrameSet("*", FRAMESET_VERTICAL, 0, $noframes);
    $wrapper = &new atkFrameSet("*", $orientation);

WITH

    $topframe = new atkFrame($frame_top_height?$frame_top_height:"75", "top", "top.php", FRAME_SCROLL_NO, true);
    $mainframe = new atkFrame("*", "main", $destination, FRAME_SCROLL_AUTO, true);
    $menuframe = new atkFrame(($position==MENU_LEFT||$position==MENU_RIGHT?($frame_menu_width?$frame_menu_width:190):$menu->getHeight()), "menu", "menu.php", $scrolling);
    $root = new atkRootFrameset();
    $outer = new atkFrameSet("*", FRAMESET_VERTICAL, 0, $noframes);
    $wrapper = new atkFrameSet("*", $orientation);