athos / kitchen-async Goto Github PK

First off, thank you for this library - I am finding it to be very useful!

I think I've found a bug with using plain keywords in the -> threading macro.

Using a plain keyword, the result is passed through unchanged:

(p/-> (new js/Promise (fn [resolve reject]
                        (resolve {:x 10})))
      :x
      (print))

=>  {:x 10}
    ^ incorrect

But if we use (get _ :kw), the correct result is returned:

(p/-> (new js/Promise (fn [resolve reject]
                        (resolve {:x 10})))
      (get :x)
      (print))

=> 10
   ^ correct

Have you considered publishing this to the npm registry so consumers using lumo could pull it down using npm or yarn?

Here is an example I found for core.async: https://github.com/mfikes/andare#lumo.

Getting excited to use this library, but was hoping to find some docs on the interop syntax for js/Promise -> core.async. I noticed the library is proposing to do this. Any thoughts of when?

Could you consider releasing 0.1.0 so we don't have to depend on a SNAPSHOT dependency.

The following form should be completely valid:

(p/-> (js/fetch url) .json)

But, the expansion result of that is not:

=> (macroexpand '(p/-> (js/fetch url) .json))
(try
 (kitchen-async.promise/->
  (kitchen-async.promise/then (js/fetch url) .json))  ;; <- .json should be (fn [x#] (.json x#)) here
 (catch
  :default
  e__51305__auto__ 
  (kitchen-async.promise/reject e__51305__auto__)))