atheriel / grunge Goto Github PK

Right now seed is an unused argument to the simplex function. It should be fairly easy to use the seed as an offset in the permutation, which would give 289 variants instead of the current 1.

At present, one cannot do

let noise = PinkNoise::new(101).scalebias(5.5, 2.0).clamp(0.0, 5.0);

the conversion to using Box'd types should fix this.

At the moment NoiseModule.generate_2d() takes a Vector2 provided by cgmath. At the time I wrote them this seemed like a good choice. However, I think it now serves as a barrier to entry, and makes the API more confusing. It should be removed in favour of regular ol' x and y parameters.

This would bring the library up to part with libnoise and CoherentNoise on this front.

This would bring the geometric primitives up to part with libnoise and CoherentNoise.

I noticed while writing the examples that having extern crate cgmath at the top of every file that uses even basic functionality is a little odd. This could be fixed by using Rust's re-exporting features. I know this approach is recommended by some other Rust game math libraries.

In addition to closing other issues, a full 1.0 release should also included:

• A license
• A proper README file that corresponds to the landing page of the rustdoc documentation.

Those provided by Libnoise and CoherentNoise are equivalent to:

• ScaledBiasedNoise (added as of 178fca0)
• ClampedNoise (added as of 178fca0)
• RotatedNoise (added as of 6935a1a)
• TranslatedNoise (added as of b97f076)
• PerturbedNoise
• ModifierNoise, which takes a closure function (added as of 6138194)
• TurbulentNoise, which may belong with the fractal group instead

This should also entail adding generate() to NoiseModule, making 2D opt-in instead of the default.

• Perlin's examples:
  • Marble texture
  • Water, Clouds, Fire spheres
  • The corona movie
• The "wood" texture of libnoise.
• Toy world generation.

This would ideally include:

• Add
• Subtract
• Multiply
• Max
• Min
• Blend (which may not generalize beyond two source modules)

It is not clear that owner pointers are better than shared pointers, especially if one wanted to update the source module. Since this should be memory safe, that might be a more sensible option than cloning boxes, as is done at the moment.