Deal with maps about sassylists HOT 12 CLOSED

Should probably update debug to display maps correctly.

from sassylists.

chunk(): fail (makes no sense)
count-values(): OK (makes no sense and looks ugly)
debug(): OK
first(): OK
insert-nth(): fail
is-symmetrical(): makes no sense
last(): OK
last-index(): fail (returns null)
loop(): OK
prepend(): OK (looks weird)
purge(): makes no sense
random-value(): fail
remove(): fail
remove-duplicates(): can't be duplicate keys in maps
remove-nth(): OK
replace(): fail
replace-nth(): fail
reverse(): OK
slice(): OK
sort(): OK
sum(): returns 0
to-string(): OK

from sassylists.

Added 3 functions: map-sort-keys(), map-sort-values() and map-find-keys().

from sassylists.

@hugogiraudel Map related functions should probably be in https://github.com/Team-Sass/Sassy-Maps instead of Lists

Additionally, debugging maps works as of RC2

from sassylists.

Good idea, problem is they rely on the sort() function from SassyLists. Not sure you can do anything with those 3 functions without the sort one.

from sassylists.

As much as I kinda hate to say it, duplicate the sort function?

from sassylists.

I don't think this is a good idea. I'd rather have a clean map sort function for Sassy-Maps. Both map-sort-keys() and map-sort-values() are based on the sort() function that was initially meant to order lists, not maps.

Working out a fresh from start map function meant for maps and maps only is probably a better idea. What do you think?

from sassylists.

That works too. I figured your sort function had been optimized for maps, but if it hasn't, yah, working out a fresh one works

from sassylists.

Basically here is what I do to sort a map based on its keys (map-sort-keys):

1. I create a list out of the keys
2. I order the list
3. I find back the value from the initial map for each key
4. I make a map out of it and return it

To sort a map based of its values (map-sort-values), it's slightly more tricky since there can be multiple keys sharing the same values, so I need the helper function map-find-keys:

1. I create a list out of the values
2. I order the list
3. I find back the keys matching each value and exclude them in a temporary list
4. I make a map out of it and return it

Kind of a big process but since the sort() function is probably the most complicated one from SassyLists, I didn't want to duplicate it just to deal with maps.

On topic, I'm not sure how to do it with less code if we want to deal with maps only for Sassy-Maps, but I'll have a look at it if you want.

from sassylists.

I'm not sure, we should move this discussion to Sassy Maps

from sassylists.

Let's go. I let you open an issue. )

from sassylists.

Won't fix.

from sassylists.