Giter Club home page Giter Club logo

Comments (11)

KittyGiraudel avatar KittyGiraudel commented on May 30, 2024

Oh. I guess we should make sure npm publishes the dist file. Didn’t realise you wanted to use it like this. I can’t do that now, so I’ll tackle this some time at the end of the week-end.

from sassylists.

ncoden avatar ncoden commented on May 30, 2024

I don't want to use it like this, but I want to compile Foundation to dist/foundation.scss too and don't know how to do it properly.

My solution for now is to concatenate source files without the main file containing the @imports statements. But it only works because no source file is using @import.

from sassylists.

ncoden avatar ncoden commented on May 30, 2024

@hugogiraudel See: https://github.com/ncoden/gulp-shopify-sass ;)

from sassylists.

KittyGiraudel avatar KittyGiraudel commented on May 30, 2024

Okay so, what do we do about this? I don’t want to bring Gulp in there.

from sassylists.

ncoden avatar ncoden commented on May 30, 2024

You can:

  • Continue to concatenate your files, but without the main _SassyLists.scss. It only works because you do not have @import statements in your partials.
  • Use `gulp-shopify-sass-. It is by far the proper solution.
  • Do not compile to a dist file. You do not have dependencies to include it, so everyone can simply include stylesheets/SassyLists

from sassylists.

KittyGiraudel avatar KittyGiraudel commented on May 30, 2024

I don’t get it. Why isn’t https://github.com/at-import/SassyLists/blob/master/dist/_SassyLists.scss okay with you?

from sassylists.

ncoden avatar ncoden commented on May 30, 2024

It is okay. But I don't know how you built it, the npm run build command doesn't build that file.

Edit: I said bullshit since the begining. stylesheets/**/* does not include stylesheets/_SassyLists.scss. I thought it was. I close.

from sassylists.

KittyGiraudel avatar KittyGiraudel commented on May 30, 2024

It does.

rm -rf dist/ && mkdir dist/ && cat stylesheets/**/* > dist/_SassyLists.scss

from sassylists.

ncoden avatar ncoden commented on May 30, 2024

Yes, it does when I run the script alone, and not when I run the build command... 🤔

from sassylists.

KittyGiraudel avatar KittyGiraudel commented on May 30, 2024

Works fine here. Do you have an error?

from sassylists.

ncoden avatar ncoden commented on May 30, 2024
➜  SassyLists git:(master) ✗ rm -rf dist/ && mkdir dist/ && cat stylesheets/**/* > dist/_SassyLists.scss
cat: stylesheets/functions: Is a directory
cat: stylesheets/helpers: Is a directory
➜  SassyLists git:(master) ✗ cat dist/_SassyLists.scss | head -n 6
// SassyLists - A couple of advanced Sass list functions
//
// Official site: http://at-import.github.io/functions/
// Repository: https://github.com/at-import/functions/

@import 'helpers/missing-dependencies';

stylesheets/_SassyLists.scss is imported in dist/_SassyLists.scss, and it should not. It works fine with the npm build command. I find this weird.

from sassylists.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.