Giter Club home page Giter Club logo

Comments (6)

panwauu avatar panwauu commented on August 19, 2024

I am willing to contribute but am not familiar with the repo and also did not port such a large codebase to typescript before. I always started with typescript from the start.
What do you think? How we could structure the change?
How do we approach the step-by-step change?
Ts-node or typescript compilation?
Should we write tests first to ensure everything runs just fine?

from glee.

fmvilas avatar fmvilas commented on August 19, 2024

Glee misses out on a lot of benefits that typescript could provide here.

Would you mind expanding on those benefits? I'm all for porting it to TS but want to make sure we make reasonable decisions.

Should we write tests first to ensure everything runs just fine?

Since this library is still in its early days, I think it's just fine to port it and then add tests. Let's not make tests become a bottleneck.

from glee.

panwauu avatar panwauu commented on August 19, 2024

The main benefit of typescript is the type checking during compile time. In my eyes this can avoid many errors during runtime.
Typescript can also let us infer types from the AsyncApi document and ensure we comply with them and provide a better developer experience by autocompletion.

from glee.

fmvilas avatar fmvilas commented on August 19, 2024

I'm sold 😄 Do you want to champion this issue? I'm sure @jonaslagoni can lend a hand if needed 😄

from glee.

boyney123 avatar boyney123 commented on August 19, 2024

Should we write tests first to ensure everything runs just fine?

Yeah think this might help us now and also going forward for sure.

How do we approach the step-by-step change?

I'm happy to help here, just need some time to review the code and see how things are structured, then we can get a plan together?

from glee.

asyncapi-bot avatar asyncapi-bot commented on August 19, 2024

🎉 This issue has been resolved in version 0.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

from glee.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.