Giter Club home page Giter Club logo

Comments (3)

pllim avatar pllim commented on July 21, 2024

If we want to support "sessions", then we also need to support merging/splitting/deleting/saving/loading sessions? Or am I over-thinking this?

from astrowidgets.

mwcraig avatar mwcraig commented on July 21, 2024

I'm also inclined at this point to switch from making self.is_marking a settable property to adding a method called start_marking for a few reasons:

  • I'm encountering cases where it would be handy to:
    • name different sets of markers that are added interactively. (.e.g by labeling them "bad comparison star" or something).
    • set the marker properties along with the name
  • Better symmetry with stop_marking, currently part of the API. Right now one could do either .is_marking = False or .stop_marking().

The first point requires either switching to a method to initiate marking or creating some kind of Marking object for specifying marker metadata.

The second point could be addressed by removing stop_marking but that method has an option to clear the markers when marking is stopped.

@pllim -- if you give this change a thumbs up I'll implement it this morning.

from astrowidgets.

pllim avatar pllim commented on July 21, 2024

@mwcraig , since you have a real use case for this, 👍 from me. Thanks!

from astrowidgets.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.