Comments (5)
👎 on disallowing string for Ginga though. I don't see the point to have to manually build an astropy.visualization object when I can just pass in a string to it.
Agree, even for things other than Ginga. Almost all of the astropy stretches have defaults for optional parameters, so something like https://github.com/astropy/astrowidgets/pull/142/files#diff-6aea2ce078dbeb19a51bdb4018c2b963ffa8728ce163c5d91aeb3bf42a3a2293R337 works as long as users can change properties after the fact.
from astrowidgets.
Actually, the original implementation called for an Astropy stretch to be the value, I think it was turned into a string to get ginga working quickly, maybe?
from astrowidgets.
After looking this over some more I think it makes sense to go with 3....or maybe even disallow strings.
from astrowidgets.
I see in #126 that there is no restriction imposed on what stretch can be. It might be nice to be explicit about what is allowed, though.
from astrowidgets.
2 and 3 are basically the same solution, but just a matter of preferring method over attribute setter, or vice versa.
astropy.visualization
object when I can just pass in a string to it.
from astrowidgets.
Related Issues (20)
- Ginga: Switch from aggdraw to pycairo HOT 2
- Widget should not inherit from VBox HOT 2
- MNT: Rename default branch from master to main
- Leveraging and synergize implementation with original design HOT 1
- Add API to deal with astropy regions
- Ginga: Remove use_opencv keyword HOT 1
- rename offset_to to offset_byand have it use units HOT 4
- Consider making `marker` private and instead only set it in `add_markers` or `start_marking` HOT 6
- Change marker from a dictionary to a class or `namedtuple`, and change the name from `marker` to `marker_style` HOT 2
- Zoom: Why two ways to do the same thing? HOT 6
- Coordinates in cursor display may not be RA/Dec HOT 12
- TST: devdeps broken due to jinja2 and markupsafe conflicts HOT 1
- TST: devdeps broken because _mouse_click_cb creates canvas object with coord being None HOT 4
- deprecation of 'raDegToString' from 'ginga.util.wcs' HOT 6
- TST: image.stretch setter fails with Ginga dev HOT 2
- File loading: Just have one "load" method and let backend decide on its own what to load
- Move backend specific implementations out of this repo
- Integration test with backends and instruction for downstream testing
- Policy on how backend can propose API changes to established Protocol HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from astrowidgets.