aspirationyc / ecommerce-pattern-library Goto Github PK

Optimization suggestion
Total time expected to be saved (estimated value)
1
Remove blocked rendering resources
0.63 s
2
Adjust the image size appropriately
0.6 s
3
Provide images in a new generation format
0.6 s

I feel like my e-Commerce website only represents some of the components and variations because I had to create new pages for each component of the second surprise page. I'm pretty sure I documented everything so it should be easy to follow for a new person to use my pattern library. Only my form isn't usable because I didn't create any fields for text input with no placeholder and for text input with a placeholder. It was difficult to grasp at the beginning of the semester because I didn't get how the code will transfer to an HTML page.

Style & design – 2
My patterns follow the theme colour so it is cohesive.

Patterns – 1.5
My form isn't usable. Some of the icons I didn't use because I didn't create a hamburger menu. Also, I added a breadcrumb but my collaborator didn't use it for the product details page.

Explanations – 3
I feel like it is clear? It should be pretty straight forward.

Accessibility – 1
I only added a few accessibilities.

Semantics – 2

Responsiveness – 2
Only the content on my banner isn't responsive. I can't figure out how to fix it. I try to put it inside a grid but it still doesn't work. I probably just put it in the wrong spot.

Code quality – 1.5
It is sort of bad accessibility but the rest should be fine,

Git & commits – 3

16/24

when trying to enter the website with voiceover, unable to tab or access without clicking. Add in some aria details to make voiceover more accessible

Very funny and original site:) New weapons falls off the screen on home page

Your website is hilarious! It looks awesome! The only issue is when I resize the home page, the text on the banner floats past the bottom on the banner.

-Hard to see tab indication in navigation and footer, perhaps change the bounding box's colour
-Add skip links

There is a piece of overlapping text on the home page, the "New Weapons" section.

Very cool ideas. The checkout button in the navigation does not lead anywhere. There is some white text on the privacy page that is difficult to read on the white background.

On the homepage there is some sort of strange text error. See image directly below.

The table on the privacy page is cut off on the left page and will not scroll to reveal that hidden information. See image below:

Fix tab index, unable to tab through any of the content.

New Weapons title, paragraph, and view weapons button is overlapping, looks like it may be placed outside of a grid when it should be inclosed.

There seems to be a missing div or unit that is causing the contents to run down the side of the page. Other than that, everything else looks fine.

Hi @thomasjbradley
https://docs.google.com/document/d/1X6KW8zcqMKAbvlORxEW0s4n1sl0hm0PI1DDOdsH50yI/edit?usp=sharing

Works with all screen sizes on Opera, good job looks good, very funny! I love it

One design issue that can be fixed is the floating paragraph on right side of the Home and Weapons page. Otherwise, everything is linked properly.