Hi,

Would you mind providing versionned binaries? Something like this would be great:

https://asm89.github.io/d/twig-lint-1.0.1.phar

You can also put binaries in GitHub releases.

Versionned binaries don’t change and can be verified with a checksum. I’d like to write an Homebrew formula for twig-lint, so people would be able to install your program with brew install twig-lint, but I need a versionned URL.

Thanks!

Using ?? in a Twig templated is flagged as invalid with the following warning:

Unexpected token "punctuation" of value "?"

It is a default Twig operator (https://twig.symfony.com/doc/2.x/templates.html#other-operators) so it should be valid?

There's a syntax error that's on purpose in Symfony/Bridge/Twig/Tests/Fixtures/extractor/syntax_error.twig . Our CI always flags this one, which fails the builds.

Please create an exclude flag that takes one or multiple directories or files and that excludes it from giving errors.

This package is part of Acquia's BLT framework, but it seems to fail when using the Drupal contributed module twig_tweak. How can I get twig-lint to recognize twig_tweak functions?

to be able to use prefer-dist and benefit from cache when installing via composer update

Could you create minor versions when new changes are merged? Otherwise it's needed to use dev-master that is not recomended: https://getcomposer.org/doc/faqs/why-are-unbound-version-constraints-a-bad-idea.md

Thank you!

Can I use twig-lint to check for:

• trailing whitespace
• correct indentation
• maximum line length
• whether the template is likely to result in correct HTML

Please add some words to the README explaining the scope of twig-lint. Can I write my own sniffs like with PHP Codesniffer?

I wrote a custom Twig operator in Symfony using a Twig Extension. Symfony recognizes it just fine -- my pages render and app/console twig:lint reports the file is ok. However, Syntastic flags the line as invalid since it triggers twig-lint outside of Symfony and does not know about my extension. Is there an easy way to teach twig-lint about my Symfony extensions?

Hi,

Linter doesn't recognize same as alias fot sameas test and it throws exception:

Unexpected token "name" of value "as" ("end of statement block" expected)

http://twig.sensiolabs.org/doc/tests/sameas.html

Linter from symfony doesn't throw this error.

http://asm89.github.com/d/twig-lint.phar leverages old dependencies. I noticed it when I upgraded my app to Twig 1.14 and began using the new 'matches' function in Twig Core. Syntastic started flagging it and I discovered it wasn't linting correctly. I downloaded the source, installed new vendors & updated composer.lock, and then built a new phar with Box against the updates and now it works perfectly.

@lauriii looked at possibly using twig-lint to detect deprecated API use, see lauriii@ce92148 -- which is obviously very raw, but we were wondering if you think this would be the right tool for this and if you had better ideas?

It seems like this should pass, but fails.
The template works and looks fine when viewing pages though.

Twig Code:

{% set n = content.field_content_blocks['#items']|length %}
{% set classes = [
                'n-' ~ p,
                n is divisible by (2) ? 'n-twos',
                n is divisible by (3) ? 'n-threes'
        ] %}
        <section class="row crocosmias">
            <div class="col-xs-12 {{ classes|myextensions_join_parts }}">

Lint Error:

[ExecStack] Done in 7.663s
> validate:twig:files
Linting twig files...
Iterating over fileset files.twig...
KO in /www/repos/uwmcms/docroot/themes/custom/cust_theme/templates/node/node--fact-page.html.twig (line 28)
   26             {% set classes = [
   27                     'n-' ~ p,
>> 28                     (n is divisible by (2) ? 'n-twos',
>> An opened parenthesis is not properly closed. Unexpected token "name" of value "by" ("punctuation" expected with value ")"). 
   29                     (n is divisible by (3)) ? 'n-threes'
   30             ] %}

[error]  Executing `'/www/repos/cust_theme/vendor/bin/twig-lint' lint --only-print-errors '%s'` against fileset(s) files.twig returned a non-zero exit code.` 

When I install v1.0.2 via Composer the installed code claims to be v1.0.1:

$ twig-lint --version
Twig lint v1.0.1

I tried a few different variants of invoking Composer, but none of those installed a package that would report its version as v1.0.2:

• composer global require "asm89/twig-lint" "@stable"
• composer global require "asm89/twig-lint" "1.0.2"
• composer global require --prefer-source "asm89/twig-lint" "1.0.2"

There is an Atom linter Provider that has twig-lint as prerequisite, so I gave it a try.

But my templates do not report any linter warnings (or Errors), even if i try to do some ugly code.

Calling twig-lint in cmd line makes no difference. I always get
OK in path\filename
as an answer.

So I have to ask, what rules are checked by the linter?

I'm not sure if/how many people are still using this linter, but it needs some love.

One thing I wonder is what to do about supported twig versions. It seems Twig 1.x, 2.x and 3.x are all supported nowadays?

Hello,

Thanks for your work. I got an issue: the --only-print-errors options doesn't exist.

Do you want me to PR it?

{% if loop.index is divisible by(4) %}
Unexpected token "name" of value "by" ("end of statement block" expected).

http://twig.sensiolabs.org/doc/tests/divisibleby.html

When linting multiple files in CI it makes sense to only print the results of the failed lints. I suggested adding a flag for that in #17. One thing that concerns me is that if we add the flag there's no visibility in the amount of files that got linted in total (it might have linted none!). Let's print a summary at the end of the command. Something like:

Linted 300 files, found 0 errors

composer.json requires twig 1.*, but Asm89\Twig\Lint\StubbedEnvironment::__construct calls Twig_Environment::initExtensions which appears to have been first added in Twig 1.12.0-RC1 as of fabpot/Twig@4487387

A minor issue but a possible gotcha.

Currently only "csv" and "full" output modes are supported. It would be great to have a JSON output format as well.

How do i make the linter lint the whole file.

When the tag is a script template, the linter ruins it, you can test with any underscore template, can we ignore this specific tags somehow?

Maybe this repo could be moved to a organization to ensure further development.
Basic idea: http://fabien.potencier.org/about-personal-github-accounts.html

Two possible orgs could be: twigphp or thephpleague.

Hi,

here is an unexpected lint error :

{% if foo.attribute is same as(false) %}
    the foo attribute really is the 'false' PHP value
{% endif %}

Error :

>> 1      {% if foo.attribute is same as(false) %}
           >> Unexpected token "name" of value "as" ("end of statement block" expected).
              2          the foo attribute really is the 'false' PHP value
              3      {% endif %}

However it works with the test "sameas".

(Twig doc : http://twig.sensiolabs.org/doc/2.x/tests/sameas.html)

Thanks for your help.

Hi,

It'd be awesome to be able to have an 'only errors' option for printing out. At the moment we lint all our files in our CI process and in the majority of cases we only want the errors to be shown.

In the meantime, I've used the following to filter output:

twig-lint lint ./filepath | grep -v 'OK'

Thanks!

I get the following message while running this tool:

Deprecated: The Twig_TokenParserBroker class is deprecated since version 1.12 and will be removed in 2.0. in vendor/twig/twig/lib/Twig/TokenParserBroker.php on line 36

It would be great if lint could check for proper indentation in a twig file. Even better would be the ability to configure what it's looking for via an argument or config file. For example, tabs/spaces (and # of spaces).