Giter Club home page Giter Club logo

Comments (3)

GoogleCodeExporter avatar GoogleCodeExporter commented on September 10, 2024
It isn't improper in my opinion. In such case, there's no way to properly guess 
returnUrl, so the user must do so himself.

Or do you have any idea how to do it properly?

Original comment by [email protected] on 21 Jul 2011 at 4:03

from lightopenid.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 10, 2024
Maybe it would be better to check if realm contains wildcard and fallback to 
$_SERVER['HTTP_HOST'] if it does?

In my case the real issue is not '$this->returnUrl' but failed validation. I 
think it would be ok to check in validate() if returnUrl/realm contains 
wildcard and if it does check if returnUrl (stripped of wildcard) is suffix of 
$this->data['openid_return_to'].

Another solution would be to throw exception if realm contains wildcard and 
returnUrl is not set explicitly by user. In this case user of LightOpenID 
object would be at least aware that it's necessary to set returnUrl properly 
(I've spent hour tracking cause of failed validation ;))

Original comment by [email protected] on 21 Jul 2011 at 6:33

from lightopenid.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 10, 2024
Created a merge request to fix this issue: 
https://gitorious.org/lightopenid/lightopenid/merge_requests/13

Original comment by woody.gilk on 2 Dec 2011 at 9:28

from lightopenid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.