Comments (6)
Why?
Original comment by [email protected]
on 18 Sep 2013 at 8:12
from lightopenid.
well, there is nothing wrong with linux shell comments in php,as official
documentation states...
It is just a feature request... I am trying to conform this
http://kohanaframework.org/3.3/guide/kohana/conventions#comments maybe it also
makes sense for you...
also these sharp comments got my syntax highlighter just crazy :)
Original comment by [email protected]
on 18 Sep 2013 at 10:01
from lightopenid.
[deleted comment]
from lightopenid.
[deleted comment]
from lightopenid.
if you have not a time for that then I could prepare a patch
Original comment by [email protected]
on 18 Sep 2013 at 10:15
from lightopenid.
sh (and other shells), python, perl, ruby, php, tcl, and other languages use
#-comments. If your syntax highlighter can't handle that, it's a bug with the
highlighter, not with LightOpenID code.
php, c/c++, and java use //-comments. I personally think that #-commments are
more fitting for a dynamic language, but regardless -- I don't see a reason to
include a patch changing a completely arbitrary thing in the code, that doesn't
affect functionality, readability, robustness, or really anything else.
Furthermore, I don't consider kohana framework style conventions a superior
(or, for that matter, inferior) to other conventions, including the one that
LightOpenID uses.
In one sentence: It would be a useless change.
Original comment by [email protected]
on 19 Sep 2013 at 11:01
- Changed state: WontFix
from lightopenid.
Related Issues (20)
- version 0.5 example works but not version 0.6 HOT 3
- Ax/SReg Params may be unsigned
- LightOpenId constructor fails when trusted root URL is less than 8 chars
- Problem with curl request on a server
- Missing: A License File HOT 2
- add composer support HOT 1
- wrong mimetype check in openid.php ? HOT 3
- Use Steam as provider HOT 1
- returning clamed_id is a wrong approach HOT 5
- magic get/set methods HOT 3
- LightOpenID magic properties do not work with Twig template engine due to lack of __isset
- New release HOT 1
- keep waiting for localhost HOT 2
- Validation fails when there are accent in the required variable HOT 2
- Yahoo OpenID not working on newer versions of PHP/cURL [patch proposed]
- The regular expressions in htmlTag parse some valid responses incorrectly
- Support for OpenID Connect? HOT 1
- How to select eid applet language ?
- Unregistered domain error HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lightopenid.