Comments (4)
The exceptions thrown by LightOpenID are intended for programmers using the
library. You should catch them and then report them to the user.
While documenting them may be a good idea, I see no point in adding i18n
support.
By the way, you probably mean internationalization (i18n), not localization
(l10n).
Original comment by [email protected]
on 9 Apr 2011 at 12:07
- Changed state: WontFix
- Added labels: Type-Enhancement
- Removed labels: Type-Defect
from lightopenid.
Also, I've just noticed that LightOpenID forwards curl errors as exceptions if
there are any, so it's not even possible to provide i18n for them.
Original comment by [email protected]
on 9 Apr 2011 at 12:16
from lightopenid.
Oh, I thought the exceptions were for the user. I should probably read
http://www.php.net/manual/en/language.exceptions.php and
http://www.php.net/manual/en/class.exception.php
At the moment, I use this code-structure:
try {
[OpenID-related code, just like in the example]
} catch(ErrorException $e) {
echo $e->getMessage();
}
As my users are more likely to be able to understand German than English,
should I use a structure like this:
try {
[OpenID-related code, just like in the example]
} catch(ErrorException $e) {
switch($e->getCode()){
catch 0:
echo "My error-message in german.";
break;
catch 1:
echo "Another translated error message.";
break;
default:
echo $e->getMessage();
}
}
> By the way, you probably mean internationalization (i18n), not localization
(l10n).
Oh, thanks for the hint. Yes, I ment i18n.
This enhancement can be closed.
By the way, how can I submit Enhancements? I can't see any way to set the
Priority or the Type of a bug.
Original comment by [email protected]
on 11 Apr 2011 at 6:38
from lightopenid.
Apparently, people who are not project members can't submit issues with labels,
and I can't change it anywhere (according to
http://code.google.com/p/support/wiki/Permissions). That's not a big problem
though, since I label the issue correctly when I answer anyway.
Original comment by [email protected]
on 11 Apr 2011 at 10:01
from lightopenid.
Related Issues (20)
- version 0.5 example works but not version 0.6 HOT 3
- Ax/SReg Params may be unsigned
- LightOpenId constructor fails when trusted root URL is less than 8 chars
- Problem with curl request on a server
- Missing: A License File HOT 2
- add composer support HOT 1
- wrong mimetype check in openid.php ? HOT 3
- Use Steam as provider HOT 1
- #-comments HOT 6
- returning clamed_id is a wrong approach HOT 5
- magic get/set methods HOT 3
- LightOpenID magic properties do not work with Twig template engine due to lack of __isset
- New release HOT 1
- keep waiting for localhost HOT 2
- Validation fails when there are accent in the required variable HOT 2
- Yahoo OpenID not working on newer versions of PHP/cURL [patch proposed]
- The regular expressions in htmlTag parse some valid responses incorrectly
- Support for OpenID Connect? HOT 1
- How to select eid applet language ?
- Unregistered domain error HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lightopenid.