Giter Club home page Giter Club logo

voxsmart's Introduction

voxsmart

Simple application that parses dialled numbers into international numbers.

Assumptions:

Assuming all user numbers start with international dialing code.

Also Hong Kong has National Prefix of '0' but that was missing from the example table ? I added it assuming it was reqd.

Not sure why country code was a map between string and integer, this is wrong as barbados has a int'l code of "+1-246"? So assuming these codes are not going to be used.

I would need to investigate whether the possibility fo clashing codes, becuase in NumberParser.findCountryCode() I currently pick the very first match. It maybe that this is fine, but i would have test further.

Possible improvements:

I would also change the way the code works, utlising DI and spring to perhaps inject the map in via a config file. And have each country represented by a class object. This would allow me to place some rules inside those objects.

voxsmart's People

Watchers

 avatar  avatar

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.