There is possible that hash will differ when new version is released (and URL is static; CCleaner stuff for example)

It would be good to first run checkver, wait for result.

1. New version
   1. Comment about new version was released and there is need to wait for excavator
2. No new version
   1. Just post PR with new hashes

Please see run log for pure result of all checks

#20

When PR is created from forked repository initial API call suffer from Resource not accessible by integration

Now:
https://github.com/Ash258/GithubActionsBucketForTesting/runs/184991649

Before:

Ash258/GithubActionsBucketForTesting#66

There should not be needed to pass Issue (PR, Scheduled) as args.

$global:TYPE = $env:GITHUB_EVENT_NAME

Edit workflow files for all repositories

• https://github.com/Ash258/scoop-Ash258/
• https://github.com/Ash258/Scoop-Jetbrains
• https://github.com/Ash258/Scoop-Sysinternals

This is pretty hard to handle as it require lots of manual checks.

It needs to be limited to 7z/zip files only.

Would it be more suitable to create scoop native binary for this?

• Implement actual action
• Support env = { SPECIAL_SNOWFLAKES = 'curl,brotli' }
• Support env = { SKIP_UPDATED = true }
• Resolve how to post log into some issue (#20)
  • Or how to properly expose log for all users
• Protected branches (#49)

On push it could handle various things:

• Hash check
• URL validity
• Extract_dir
• ...

Relate: ScoopInstaller/Scoop#2667

Aria2 usage is now initialized. There are few problems that needs to be investigated

Starting download with aria2 ...
Exception caught
Exception: [download_helper.cc:563] errorCode=1 Failed to open the file /SCOOP/cache\xmake.txt, cause: File not found or it is a directory

ERROR Download failed! (Error 1) An unknown error occurred
ERROR https://github.com/xmake-io/xmake/releases/download/v2.2.7/xmake-v2.2.7.win64.zip
    referer=https://github.com/xmake-io/xmake/releases/download/v2.2.7/
    dir=/SCOOP/cache
    out=xmake#DL#https_github.com_xmake-io_xmake_releases_download_v2.2.7_xmake-v2.2.7.win64.zip

ERROR & '/usr/bin/aria2c' --input-file='/SCOOP/cache\xmake.txt' --user-agent='Scoop/1.0 (+http://scoop.sh/) PowerShell/6.2 (Windows NT 4.9; Core)' --allow-overwrite=true --auto-file-renaming=false --retry-wait=2 --split=5 --max-connection-per-server=5 --min-split-size=5M --console-log-level=warn --enable-color=false --no-conf=true --follow-metalink=true --metalink-preferred-protocol=https --min-tls-version=TLSv1.2 --stop-with-process=1 --continue
The expression after '&' in a pipeline element produced an object that was not valid. It must result in a command name, a script block, or a CommandInfo object.
+     & "$env:COMSPEC" /c $cmd
+ CategoryInfo          : InvalidOperation: (:String) [], RuntimeException
+ FullyQualifiedErrorId : BadExpression
 

Please try again or create a new issue by using the following link and paste your console output:
https:////
PS /> ls /SCOOP/cache/
xmake.txt
PS /> cat /SCOOP/cache/xmake.txt
https://github.com/xmake-io/xmake/releases/download/v2.2.7/xmake-v2.2.7.win64.zip
    referer=https://github.com/xmake-io/xmake/releases/download/v2.2.7/
    dir=/SCOOP/cache
    out=xmake#DL#https_github.com_xmake-io_xmake_releases_download_v2.2.7_xmake-v2.2.7.win64.zip

Check what happen if there are no manifests changed. Only binaries for example

If loaded manifest and version parsed from issue title does not match post some comment Latest version of manifest is <ver>. You reported different version. Please run scoop update and then try again.

For some reason when url contains rewrite (#/dl.7z) it will result as broken URL.

Broken, which should be OK
Ash258/GithubActionsBucketForTesting#164

When there is no rewrite it is OK.
Ash258/GithubActionsBucketForTesting#162

If repository contains protected master it will need to provide ssh key as secret.

if ($env:SSH_KEY) {
    Set-Content "$HOME\.ssh\id_rsa" $env:SSH_KEY -Encoding ASCII
} else {
    git config remote-url ... $user:$token
}

If it will work. Note, example and instructions how to add have to be added into Readme.

#14

• Test result of & "$env:SCOOP_HOME\bin\scoop.ps1" install /github/workspace/bucket/jx.json
  • Not working due to COMSPEC
• install_app 'jx' (default_architecture) $false $null $true $true

Trigger Pull request action when PR comment /verify is added
https://developer.github.com/v3/issues/comments/

https://developer.github.com/actions/managing-workflows/workflow-configuration-options/#events-supported-in-workflow-files

This will save me lots of checks and my sanity.

If bucket do not have nested bucket folder fail and create new issue about this

https://github.com/Ash258/scoop-Ash258/runs/165121799

This could prevent logs being saved at full length.
Count or just long line of manifests could be enough.

Then it would be possible to put public url into comment, so everyone can see log of action, not only collaborators.

Related: #13, #11, #15, ...

Installation of manifests could be easily done. Only question about performance, build time is on deck.

• Fix error state handling of binary https://github.com/Ash258/GithubActionsBucketForTesting/runs/153999789
• PR Title version

Add check for label existence before removing / adding them.

If there is no autoupdate.hash just test causal urls.

1. Metalink
2. Header
3. Suffixes for url ($url.$_)
   1. .sha256
   2. .sha1
   3. .sha512
   4. .md5
4. Suffixes for url without extension $baseurl/$fileNameNoExtension.$_
   1. .sha256
   2. .sha1
   3. .sha512
   4. .md5
5. $baseurl/$_
   1. SHA256SUMS, SHA256SUMS.txt
   2. SHA512SUMS, SHA512SUMS.txt
   3. checksums.txt
   4. latest.yml
   5. ....
6. ....

If there are any, add new status with message that autoupdate hash is possible

Actions will be globally released on November 13

HCL will be deprecated in favour of YAML.
https://developer.github.com/actions
https://help.github.com/en/articles/migrating-github-actions-from-hcl-syntax-to-yaml-syntax

TODO:

JetBrains
SysInternals
GenericBucket
Ash258

PR action should exit with nonzero code if there is some proble (block PR merging)

In other actions I feel comment is better than failed actions

Test result of (Get-content -raw $manifest.fullname) -eq ($object | ConvertToPrettyJson)

• ConvertToPrettyJson
• Properties order

Sanitize events folder:

• Opened
  • Fork
  • Normal
• Commented
  • Fork
  • Normal

• If property exists
• If it is valid spdx identifier
  • No? Is there URL?

- [ ] License
	- [ ] Valid SPDX Identifier
	- [ ] Invalid + URL

• This will require adding $Indent switch to new-checklistitem function

• Setup appveyor for this project
• add proper vscode settings and editorconfig

Accept: application/vnd.github.v4+json

https://developer.github.com/v4/
https://developer.github.com/v4/guides/migrating-from-rest/
https://developer.github.com/v4/guides/forming-calls/#authenticating-with-graphql

Issues

1. Hash check failed
   1. & bin\checkhashes.ps1 $name -Update
   2. if git status
      1. Push (if possible)
         1. Or add label verified, package-fix-needed
      2. else
         1. Comment "Cannot reproduce"
2. download failed
   1. [ ] extract_dir Deferred as it would need lots of work and use cases covered (#11)

PRs

opened, commented with special comment

PR Workflow could be triggered with adding label TRIGGER ...

It would be nice if on property could be more detailed. Report to github and wait for response

Instead of issue_comment could be issue_comment.created

While running autoupdate it should be easy to match something like cannot extract hash and reflect it in final comment.

- [x] Autoupdate

- [ ] Autoupdate
	- Hash extraction failed

https://github.com/Ash258/Scoop-GithubActions/wiki/Pull-Request-Checks

Investigate if I can push to repository from action container with just GITHUB_TOKEN

Create proper examples

As file will grow it will be nice to sanitize it into more modules

Initial version (1.0.0) will contain main functionalities for automatic responses and time savers for maintainers.

• Hash check fails validator

• Download failed validator

• New manifest in PR validation

  • Hashes
  • Checkver
  • Needed properties

• "Excavator"

  • Iterative pushing done by auto-pr

• Polish README

  • Synchronize terminology

• Polish posted comments before first release

• Release and tag initial version

  • 1.0.0 tag requirements
    • Events folder
      • All events needs to be in place
    • Issue handler
      • hash check
      • download failed
        - [ ] Aria2 support
    • PR
      • Commented
        • Fork
        • Normal
      • Created
        • Fork
        • Normal
    • Excavator

• Protect Master

  • Create also stable branch, which will be almost equal with master
    • Users will not need to look for latest version
    • This may not be even point when deployed to marketplace
      - [ ] Icon ScoopInstaller/Scoop#2261

• Register official action to marketplace

  • https://developer.github.com/marketplace/actions/publishing-an-action-in-the-github-marketplace/

• Adopt in buckets

  • GenericBucket
  • JetBrains
  • Sysinternals
  • Ash258
  • Main
  • Extras
  • Internal corporate repositories
    • Ixx
    • Dxxxxxxxx
    • Pxxxxx
    • Qxxxxx
    • Ixxx

Maybe there is not needed to provide real email. Try with something like [email protected]

🎉🎉🎉🎉 Button is finally available 🎉🎉🎉🎉

On saturday there is need to be new release with marketplace. #32 Is good candidate for readme updates, which is pretty easy to fix

Issue action could be triggered via label added.

verify label is the most suitable for this

• Basic implementation
• Information about causes
• Aria2 support

Add all possible events into events folder

• PRs.opened.json
• PRs.fork.opened.json
• PR.commented.json
• Issue.commented.json
• Issue.opened.hash.check.failed.json
• Issue.opened.extract.dir.json
• Issue.opened.download.json
• Scheduled.json
• Push.json

New generic function with support for nested objects is needed for more advanced checks.

New-CheckList {
    param([Hashtable] $Statuses)

	return New-Array # String 
}

$statuses = @{
	Alfa = $true
    Cosi = @{
		Ahoj = $true
		AhojA = $true
    }
	Broken = @{
		Hello = $false
		COSi = $true
	}
}

This object will result in:

- [x] Alfa
- [x] Cosi
	- [x] Ahoj
	- [x] AhojA
- [ ] Broken
	- [ ] Hello
	- [x] COsi

In newer version of actions there is something wrong. It looks like that git config --global user.name $env:GITHUB_ACTOR will be needed now.

Updating ...
hub pull origin master
From https://github.com/Ash258/GithubActionsBucketForTesting
 * branch            master     -> FETCH_HEAD
Already up to date.
hub checkout master
Switched to a new branch 'master'
M	.github/workflows/issue_comment.yml
M	.github/workflows/issues.yml
M	.github/workflows/pull_request.yml
M	.github/workflows/schedule.yml
Branch 'master' set up to track remote branch 'master' from 'origin'.
Pushing updates ...
hub push origin master
fatal: could not read Username for 'https://github.com': No such device or address
^^^ Error! See above ^^^ (last command: hub push origin master)

Triggers

• Opened PR
• Opened PR from fork
• Comment❓❓
  • Anyone could comment to trigger this action
  • When PR is updated, then anyone could comment something like: /verify to trigger action again
• Cleanup Test-PRFile function
  • Export checks into own funciton with $status, $manfiestOb, $manifestGci

Checks

1. Description
2. License (Add note to children list, about what is wrong)
   • License property exists, but it is not valid SPDX identifier
3. Hashes
4. Checkver
5. Autoupdate
6. Install (#59)
7. Format (#24)

Expected comment:

Thanks for contributing. Your PR did not pass requirements.

### Manifest 1

- [x] Description
- [ ] License
- [x] Hashes
- [x] Checkver
- [x] Autoupdate

### Manifest 2

- [x] Description
- [x] License
- [x] Hashes
- [x] Checkver
- [x] Autoupdate

Thanks for contributing. PR looks good.

Wait for review from human collaborators.

Implementation:

Best possible to temporary save into some hashtable:

@{name = 'Manifest1'; 'Checkver' = Passed; 'Properties': 'OK | list of failed properties'}

Automatic pushing of hash fails should not be prohibited for obviouse reasons.

PR creation should be better approach