ascrod / readerview Goto Github PK

Current orange color is a holdover from Firefox. The color should be changed to a more Pale Moon-themed shade of purple.

Reader key combo string is not intended to be localized. Delete extraneous dtd file and hardcode the key in XUL.

The text size buttons have stopped working. An example below.

See also: https://bugzilla.mozilla.org/show_bug.cgi?id=1153393

See if it's possible to leverage session store for this, similar to the existing FF/Basilisk code.

When entering Reader Mode, a favicon for the page should be displayed in the tab if it exists. This works fine with Basilisk's built-in mode, but not with this add-on in Pale Moon.

This is actually a long-standing issue, but it needs to be documented nonetheless.

This issue is a follow up to #14. An option was added to disable the shortcut, but it would be beneficial to also be able to change the key configuration as well. Given the discussions here and here, it's unlikely that any single shortcut is going to make everyone happy.

Not sure when I'll get around to this, but it's here.

UI update code in ReaderParent module should assume that the user may have removed the button. Call to button update code should be added to window.addEventListener("aftercustomization").

This may be a CSS or rendering issue.

E.g. https://finance.yahoo.com/news/marvell-buy-inphi-10-bln-110101936.html

Yet they work fine with firefox's reader mode.

Commented code was left in for reference, but should now be removed.

Most of the localization files are missing a property for "readerView.disabled", which displays in a tooltip on the Reader View button when it is grayed out. In English, the tooltip says "Reader View Unavailable". I've added some preliminary translations for several locales, but these are very rough and likely need to be proofread by native speakers.

Suggestions and pull requests for this are more than welcome!

Default Ctrl+Alt+R shortcut may be problematic or unusable for certain keyboard layouts, such as AltGr. Possibly provide an option to configure or disable the shortcut in about:config.

Update Readability.js and JSDOMParser.js to the latest versions available from Mozilla Readability Library.
Currently using the version supplied with Basilisk v2017.11.12

instead of the robotic sounding defaults, allow the option to use gTTS

https://pypi.org/project/gTTS/

See also: https://forum.palemoon.org/viewtopic.php?p=129429#p129429

When saving a page while in Reader View, images do not save with the rest of the page content. This only manifests with the Pale Moon extension, and not with the integrated Reader View in Basilisk, so I think we can rule out issues with the platform code here.

This functionality exists in the original Firefox code, but is solely used for Pocket integration. Create a similar, non-e10s API for adding additional buttons in case someone wants to add Pocket, Narrate, or other custom tools to the toolbar.

See also: https://forum.palemoon.org/viewtopic.php?f=46&t=17660&start=40#p133519
Similar to what Better Reader has done, allow for picking and saving a custom font and/or color scheme.

Buttons, enter on input stop working, search provider's logo disappears.
(Double checked with only Tab Groups enabled)

But many thanks for the port! Really missed it.

As mentioned here, simple language detection could be implemented by processing the HTML lang attribute and/or charset tag. If language detection fails, either default to English or hide the reading time estimate.

This option is present in Firefox and Basilisk, and should be implemented here as well.

Will need to use a "first run" preference for this.

Since Pale Moon does not implement e10s, the ReaderParent module is not necessary. Functionality should be moved to readerMain.js file instead.

I am not a developer and don't understand anything about programming, but I hope this is the right place to post this request. I make extensive use of your Reader View in a Pale Moon fork called ArcticFox. Is there a way 1. to have the date of the articles show in reader mode (it never does), and 2. less important, remove the expected reading duration (useless to me)?

Thank you, your work and the features added to the old Firefox version are very much appreciated.

RobertJ

I'm using reader view in combination with the extension Website Navigation Bar and the latter uses <link/> tags in the <head/> section to offer a navigation bar right into Pale Moon's native UI.

Reader View discards <link/> tags from the <head/> section on reader mode. It'd be nice if these tags are preserved so I can use reader view to read the page and website navigation bar to navigate among the sections. This would be a great combo to read online manuals.

Should be able to pull aboutReader.properties from l10n-central for each supported language.

Use an about:config option to toggle between fixed and free locations.

This is due to a broken reference to "getBoolPref" in readerUtils.js. This call needs to be changed to explicitly use "Services.prefs.getBoolPref".

This action fails with the following error in the console:

Error: Couldn't create URI from <uri> to download: [Exception... "Not enough arguments [nsIIOService2.newURI]"  nsresult: "0x80570001 (NS_ERROR_XPC_NOT_ENOUGH_ARGS)"  location: "JS frame :: resource://readerview/ReaderMode.jsm :: _downloadDocument :: line 250"  data: no]
Source File: resource://readerview/ReaderMode.jsm
Line: 254

Reader View must be exited and re-entered to properly display the document.

This is really two separate bugs, but they might be related so I'm reporting them together.

Steps to reproduce:

1. Click an anchor link on the page, then enter Reader View. RV begins at the top of the page, not at the selected anchor.
2. While in Reader View, click an anchor link on the page. RV exits when the anchor is navigated to.

Example page for reference: https://docs.microsoft.com/en-us/dotnet/standard/base-types/regular-expression-language-quick-reference

This should be doable with a boolean preference and some scripting that sets the inline style display for each image to none, or clears it. And a new button.

See also: https://forum.palemoon.org/viewtopic.php?f=46&t=17660&start=40#p134975

Add one or more context menu entries for opening a selected link in Reader View. These entries may include "Open in current tab" and/or "Open in new tab". I think it would be ideal if the implementation also works around redirects (e.g. Google search results) and would only open Reader View if the page is "readerable".

Possibly also include an option to show or hide these context menu entries.

Restrict logging to debug mode.

It caused some buttons to move to far left (I had arrows, reload etc on right), and some were dropped into Customize palette. I did not try and trace any exact cause, just reverted to a profile backup. I realize this info is not of much use, sorry.

This work is already underway, but I'll make an issue anyway.

Some Reader View components are being integrated into toolkit for the upcoming release of Pale Moon 28. The add-on will need to be updated to take advantage of this as well as to maintain some of the PM-specific changes that will not be in UXP.

• Remove local components where necessary and update paths to point to toolkit components.
• Implement any UXP-specific compatibility fixes.
• Move show/hide images functionality into readerMain.js and utilize the button add/remove API in toolkit.
• Migrate toolkit-specific preference values from "extensions.reader" to "reader".

Hi Ascrod,
Thanks for this, I cannot seem to get it work though. There is no option to enter Reader View even after I installed it.

Create 48x48 and 64x64 icons and update install manifest

If possible, show the original URL when in Reader Mode. See if urlbar bindings can be implemented.

As reported on the forum, the add-on may be preventing shortcut keys used by other extensions from functioning correctly. This is likely related to the new shortcut-configuring feature that was introduced in the latest release.

See also: https://forum.palemoon.org/viewtopic.php?f=46&t=17660#p129520

Add UI elements, either a prefs window or buttons on the reader's toolbar, for changing certain preferences. This would include the location.urlbar pref and the hotkey pref.