asafkorem / costouchvisualizer Goto Github PK

How about release a version 1.0.3 to Cocoapods to include bug fixes after 1.0.2? Thanks.

Is it possible to create a tweak for jailbroken IOS out of this, so it works everywhere?

It would be awesome to have the COSTouchVisualizer show touches during a recording session using Apples ReplayKit - or to be able to configure the behaviour by using a delegate method.

Don't know if this is somehow related to #27 though.

Hi,

I tried to follow your instructions:

To run the example project; clone the repo, and run pod install from the Example directory first.

I did:

shell> git clone [email protected]:conopsys/COSTouchVisualizer.git
shell> cd COSTouchVisualizer
shell> cd Example
shell> pod install
Analyzing dependencies
Fetching podspec for `COSTouchVisualizer` from `../COSTouchVisualizer.podspec`
[!] Unable to satisfy the following requirements:
- `COSTouchVisualizer (from `../COSTouchVisualizer.podspec`)` required by `Podfile`

If however, I change the path to be an absolute path, it works fine:

# Set :path => /Users/joel/Documents/COSTouchVisualizer/COSTouchVisualizer.podspec
shell> pod install
Analyzing dependencies
Fetching podspec for `COSTouchVisualizer` from `/Users/joel/Documents/COSTouchVisualizer/COSTouchVisualizer.podspec`
Downloading dependencies
Installing COSTouchVisualizer (1.0.1)
Generating Pods project
Integrating client project

Obviously you can't commit the absolute path to the Example project.

I am on OS X 10.9.2.

Any ideas?

Thanks. By the way, this pod is awesome stuff!

I'm not able to see the touches during recording using QuickTime. The visualizer itself seems to work; at least, as soon as I set

func touchVisualizerWindowShouldAlwaysShowFingertip(_ window: COSTouchVisualizerWindow!) -> Bool {
  return true
}

Touches are shown correctly. But not, if this is set to return false. Tested with master as well as with 1.0.6 - both behave equally wrong. Running iOS 10.2 on an iPhone 6s.

Sometimes the visualized touches do not disappear. But they still do that jellyfish movement. The problem occurs randomly, sadly I haven't found a way to reproduce it. The project is entirely written in swift and the COSTouchVisualizer (1.0.3) is added via CocoaPods. Do you have any idea what the cause could be?

We recently had to remove this library from our application as it was causing the CPU to be pegged at 100% even when the window's effects were not enabled. We had everything set up with the default configuration.

The problem line looked to be here: https://github.com/conopsys/COSTouchVisualizer/blob/master/Classes/COSTouchVisualizerWindow.m#L222
This timer constantly runs the target method for us even if the app user doesn't have the touch effects enabled at all, which is not ideal. Even if the effect was on, the timer shouldn't run if the visualization is not currently happening.

Hi,

great library. I have been looking for a library that shows touches because I need to make some promotional videos of an app of mine, and I chose this one because I liked the ripple effect. No other touch visualization library that I checked had that!

But I noticed that the ripple effect no longer works in iOS 13.5.1 (I suspect it doesn't work since iOS 13, but I haven't checked. It works in iOS 12.4.1)

The fix is easy. Just change line 114 of COSTouchVisualizerWindow.m from

[rippleView setFrame:CGRectInset(rippleView.frame, 25, 25)];

to

[rippleView setFrame:CGRectInset(rippleView.frame, 24, 24)];

It seems that iOS 13 doesn't like to animate the frame property to a zero-sized rectangle.

Is this library still maintained? The master branch is outdated and crashes, and the FixBugsAndUpdateAPI branch has not yet been merged into master. I'm currently using the FixBugsAndUpdateAPI branch together with the single-line change mentioned above.

All the best,
Michael

I'm using Swift 3, and the sample code.
When compiling, I get this error:

Command failed due to signal: Segmentation fault: 11

1. While emitting SIL for getter for window at /AppDelegate.swift:14:14

By removing the lazy keyword, this error disappears, but I got a new error at:
customWindow.touchVisualizerWindowDelegate = self

Any idea to solve this issue ?

Thx,
Arnaud

want to see touch on single uiview not on uiwindow. is that possible?

Hi,

We have been using COSTouchVisualizerWindow in our apps for years, in a non active state at launch and can be enable by a switch inside the app. It didn't have any problems so far. However, since some iOS 16 version, even if the fingertips display is not enabled by the delegate (touchVisualizerWindowShouldShowFingertip returning false), there is a strange behavior:

• our navigation controller and top view controller only allow landscape rotations (through supportedInterfaceOrientations); it worked well before
• since maybe iOS 16.0 we don't know exactly, if the app is launched and no tap is performed at all, the rotation works as expected: we turn the iPad and the window only rotates when it goes from landscape left to landscape right and the other way round
• after any tap on the screen (ie. anywhere, without hitting any button or active element), the rotation gets broken: when rotating the iPad to portrait, the window has a rotation animation (we see the black corners rotating) while the controller stays landscape, and many other things get broken like the keyboard is showing in portrait, modals are portrait, ...
• if we replace COSTouchVisualizerWindow by UIWindow, the problem doesn't appear

Very strange behavior, would anyone have any ideas?

We are using tag 1.0.6.

Figure out how to get this working on iOS8

The touches circles are quite useful when recording a product introduction video which has nothing to do with debugging. So the name Debug Mode is somehow confused. I suggest to rename it or just describe it as "To show in simulator". Excellent work anyway~

How can I switch between visibility mode? Before refactoring to modern Objective-C, visibility was controlled - (BOOL)isActive method. But after refactoring - we have read-only COSTouchVisualizerWindowTouchVisibility.

Hey guys, I have submitted a pull request that fixes compilation issues for swift projects. Added some description to the pull request.

#19

Let me know if there is something else that needs to be done.
Cheers!

Operations related statusbar like "hide/show statusbar" and "content color" are not work correctly.

The framework target contains its own Info.plist file in the copy bundle resources phase. The Info.plist doesn't need to be in the copy bundle resources phase and it causes a warning when building the framework. It's not causing any actual bugs but I'd appreciate if you could remove the file from the copy bundle resources phase anyway!

Hey,

The animated gif looks awesome!

But running the Example project on both the iOS 7.1 simulator and an actual iOS 7.1 iPhone or iPod Touch 5G, I don't see the animated touch circles.

Any ideas why?

Thanks!

Joel

Stripe video has a really nice animation for touches.

https://stripe.com/img/dashboard_iphone/screencast.mp4

Hi,
when i launch the app from my device i get every times this error:

Apr 13 00:20:35 iPhone MyApp[1443] <Error>: +[UIView animateKeyframesWithDuration:delay:options:animations:completion:]: unrecognized selector sent to class 0x3b156a08
Apr 13 00:20:35 iPhone MyApp[1443] <Error>: *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '+[UIView animateKeyframesWithDuration:delay:options:animations:completion:]: unrecognized selector sent to class 0x3b156a08'

P.S. in the iPhone Simulator this never heppen...
Thanks for the work!! :D

How can the TouchVisualizer be used in a Watchkit App?

Hi, it seems your CocoaPods spec for COSTouchVisualizer was hacked yesterday

Repo url in the spec is conopsys/COSTouchVisualizer, which is different from this repo, and contains only one text file
https://cocoapods.org/pods/COSTouchVisualizer

Possibly that old account was recreated

If you can access your CocoaPods account, you may want to remove or update it
Thanks

After properly adding the pod and putting

class AppDelegate: UIResponder, UIApplicationDelegate {
    lazy var window: COSTouchVisualizerWindow? = {
        COSTouchVisualizerWindow(frame: UIScreen.mainScreen().bounds)
        }()
   ...
}

There is a segmentation fault

error: use of undeclared type 'COSTouchVisualizerWindow'
    lazy var window: COSTouchVisualizerWindow? = {
                     ^~~~~~~~~~~~~~~~~~~~~~~~
0  swift                    0x0000000101cd8968 llvm::sys::PrintStackTrace(__sFILE*) + 40
1  swift                    0x0000000101cd8e54 SignalHandler(int) + 452
2  libsystem_platform.dylib 0x00007fff88cb1f1a _sigtramp + 26
3  libsystem_platform.dylib 0x0000000000000040 _sigtramp + 1999954240
4  swift                    0x000000010209dea2 mapSignatureFunctionType(swift::ASTContext&, swift::Type, bool, bool, bool, unsigned int) + 66
5  swift                    0x000000010209dcf3 swift::ValueDecl::getOverloadSignature() const + 531
6  swift                    0x0000000101fb35cd checkRedeclaration(swift::TypeChecker&, swift::ValueDecl*) + 397
7  swift                    0x0000000101fad073 swift::ASTVisitor<(anonymous namespace)::DeclChecker, void, void, void, void, void, void>::visit(swift::Decl*) + 2723
8  swift                    0x0000000101f9df0b swift::TypeChecker::typeCheckDecl(swift::Decl*, bool) + 123
9  swift                    0x0000000101f8425a swift::performTypeChecking(swift::SourceFile&, swift::TopLevelContext&, unsigned int) + 1514
10 swift                    0x00000001012b95dd swift::CompilerInstance::performSema() + 2381
11 swift                    0x000000010101e788 frontend_main(llvm::ArrayRef<char const*>, char const*, void*) + 2008
12 swift                    0x000000010101c86d main + 1677
13 libdyld.dylib            0x00007fff8d0405c9 start + 1
14 libdyld.dylib            0x000000000000005e start + 1929116310