arunsathiya / set-output-janitor Goto Github PK

The code contains the logic to invoke system command line tools to find and replace the set-output line. Instead of this use go string manipluation.

Should figure out an automated way to delete forked repositories once PRs are merged upstream.

As a stopgap, can probably run a manual check on pending PRs vs existing repositories and delete the ones that don't have any open PRs.

At this time, the implementation is brittle in the regard that there might be matches remaining. Should warn user about those matches for manually cleanup, before/after PR creation, ideally before.

Like, after raising a pr, you can have a column to track it. URLs and everything.

One example is:

2024/01/20 18:37:18 file creation error: open contact-center-ai-samples/.github/workflows/inactive/dialogflow-cx-python.yaml: no such file or directory
panic: send on closed channel

goroutine 112 [running]:
main.main.func7({0x1032799b0?, 0x140001b2840?})
	/Users/arun/go/src/set-output-janitor/main.go:275 +0x108
created by main.main in goroutine 1
	/Users/arun/go/src/set-output-janitor/main.go:268 +0xf04
exit status 2

Should stop using my personal account to submit PRs, and rather attribute them to a bot action:

https://docs.github.com/en/apps/creating-github-apps/authenticating-with-a-github-app/authenticating-with-a-github-app-on-behalf-of-a-user

https://github.com/arunsathiya/kubeflow-manifests/blob/a63ddf96a6cb3fd24839761cd833cdf90dff1be7/.github/workflows/build_push_website_folder.yml#L31

My forked repositories will need to remain active until the PRs are merged upstream, so in such cases, there's a good chance that the same repository name shared between two organizations will conflict.

Should think of an approach here.

There are some references to five seconds timeout, which need to be handled better, I think:

• After fork creation, which should be better-handled by awaiting
• Between commit creation and fork creation

At least two incorrect replacements have been found 😞

• IBM/gevent-for-z@ab843c8
• IBM/grpc-for-Z@ee436a2

patch2pr can be a good choice to avoid cloning, thus speeding up the processes significantly.