aruanoc / nfg-client Goto Github PK

When a string entered by the user to be sent to NFG, such as first name, last name, etc., includes certain characters (<>&), the soap message will fail. These characters should be encoded while the xml is built.

Looking at the code, it appears that the only change would be in the hash_to_xml method, by adding an encoding step (CGI.escapeHTML(v)):

    def hash_to_xml(hash)
      hash.map do |k, v|
        text = (v.is_a? Hash) ? hash_to_xml(v) : CGI.escapeHTML(v)
        # It removes the digits at the end of each "DonationItem" hash key
        xml_elem = (v.is_a? Hash) ? k.to_s.gsub(/(\d)/, "") : k
        "<%s>%s</%s>" % [xml_elem, text, xml_elem]
      end.join
    end

If you think this is the correct solution, let me know and I will issue a pull request.

Currently, the response object returns a TotalDeductFee that has been set to the TotalChargeAmount. Should it be set to the TotalDeductFee amount?

        'TotalAddFee' => response.elements['TotalAddFee'].get_text.to_s,
        'TotalDeductFee' => response.elements['TotalChargeAmount'].get_text.to_s,
        'TipAmount' => response.elements['TotalAddFee'].get_text.to_s

And should the TipAmount be set to the TotalAddFee? I thought they were different?