Giter Club home page Giter Club logo

Comments (2)

peteihis avatar peteihis commented on May 23, 2024

does not properly reset the image dialog buttons when the selected image is deleted

Actually it does'n matter if the selected image was among the deted or not. What happens is that purge sets none selected, but the state of the buttons is not updates, so if the button was active before purge, it tries to open details the details window without an image...

The fix is to add hilightButtons as the last statement in private void purge(), lines 249 - 254.

I found another little gitch too. If you try to open an file with the extension .hdr and the file is something else there is an uncaught error, that will interrupt the loading. It interrups a multimple image load too, without loading anything.

The error should be handled so, that the images, that can be loaded would still be loaded and the user is notified about those that were not.

Edit: Taking the fix to the original issue a bit further, purge could check if the selected image was deleted or not. Now it simply sets none selected. :) -- And still hilightButtons() needs to be called after purge().

from artofillusion.

peteihis avatar peteihis commented on May 23, 2024

The error should be handled so, that the images, that can be loaded would still be loaded and the user is notified about those that were not.

Got that. Removed return from the catch block. That unnecessrily interrupted the entire loading process.

Q: Does it make any sense to printStackTrace() in cases like this. We know where the error happened and the output tells very little (or the way I see it , nothing) of, what was wrong with the file. The listed command-chain through all the java-libraries is hardly anything that helps or that we could do anything about.

from artofillusion.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.