Comments (9)
Thanks @gajjargaurav! 🌟 Perhaps the jar should be enabled by default, with the option to disable it on per-scenario basis?
from artillery-core.
@hassy could do that. However request by default doesn't set it. If we set up that as default we are making an assumption that users would want that most of the time. I don't see that to be the case.
from artillery-core.
@gajjargaurav Yes, perhaps, although if the server doesn't send any cookies, there would be no performance overhead - and if it does, then the user probably wants these cookies to be sent on subsequent requests. Either way, I think cookies
should be a global option (set in config.defaults
), and it should be possible to set it on individual scenarios. The implementation should also make sure that there's a different cookie jar for every running scenario, rather than a global request
one.
from artillery-core.
Yes, that sounds like a plan. Thanks
from artillery-core.
@hassy , I've done a quick fix for now if that is acceptable. I would like to extend that to actually pass in cookies to set to in the cookie jar.
from artillery-core.
@gajjargaurav It does not seem to work as described in the issue, i.e. cookie support should be enabled by default.
I added a basic test case in this commit: e7ac291 - this makes sure that cookies are enabled by default - will you have a chance to rewrite the PR so that this test passes? If not, I'm happy to do it.
from artillery-core.
@hassy , I will look into it during the weekend and update the PR.
from artillery-core.
@gajjargaurav Awesome, thanks! :)
from artillery-core.
@hassy I did get it working locally for global request object, however I am having issues doing with a separate jar for each scenario
from artillery-core.
Related Issues (20)
- Feature Proposal: File Upload HOT 6
- Artillery does not return with certain malformed requests
- Artillery is connecting twice with socket.io HOT 14
- Known vulnerability in npm dependancy ws. HOT 2
- Known vulnerability in npm dependancy tough-cookie
- Question/bug?: customStats being overwritten HOT 1
- beforeReqeust's requestParams can't be customized. HOT 1
- Send binary packet through WS? HOT 1
- WS get received data? HOT 1
- Add socketio query param on connect event HOT 3
- Match json fails for numeric value
- Variables with 0 numeric value are always empty string
- Expose http response body to afterResponse HOT 2
- Socket.IO Engine - Emit Callback Data HOT 1
- Double send in socket.io engine HOT 3
- Add raw TCP socket engine
- [Feature Request] Add support for SignalR
- supporting multipart form data HOT 4
- Data got emit twice in socket.io engine HOT 2
- form not sending data HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from artillery-core.