Giter Club home page Giter Club logo

Comments (14)

SvA1 avatar SvA1 commented on June 18, 2024 2

I could help you out with the German translation.

from ergolux.

Pyr0x1 avatar Pyr0x1 commented on June 18, 2024 2

One note, the PRs aren't recognized as participating in Hacktoberfest (unless you mark them with the hacktoberfest-accepted label)

That's true. I believe the idea is that only approved and merged PRs, which are labelled as hacktoberfest-accepted, do participate in Hacktoberfest. But that's not automatic, since maintainers have to validate PRs to check whether they qualify for Hacktoberfest or not. So, unless mistaken, that label is the last step in the process and has to be added by the maintainer.

I think the label linked to the project must be hacktoberfest and not hacktoberfest-2022 to make PRs automatically detected as partecipating.

That's a good point, so I've just added that label at the project level to avoid any unexpected issues. However, after reading the Hacktoberfest validation guide I don't believe there's any automatic detection, unless PRs are merged and labelled as hacktoberfest-accepted.

Please let me know if there's any misunderstanding on my side. Also, don't hesitate to let me know if any of your two contributions (here and here) aren't recognised correctly.

I really appreciate your positive feedback!

No problem 😁 the PR were recognized correctly, thank you

from ergolux.

arthurits avatar arthurits commented on June 18, 2024 1

I have created a created a Pull Request regarding the french translation (PR #4), and, on my Hacktoberfest profile, this Pull Request has been tagged as NOT-PARTICIPATING.

Hi @Xav83,
I believe contributors have to wait untill the PR is merged, approved, and tagged as accepted.

I've just reviewed your PR and all should be right in a short period of time. Should there be any problems regarding this issue, please don't hesitate to let me know.

Merci beaucoup pour votre contribution!

from ergolux.

arthurits avatar arthurits commented on June 18, 2024 1

I could help you out with the German translation.

@SvA1, I'm really happy for your contribution. Vielen Dank!

from ergolux.

arthurits avatar arthurits commented on June 18, 2024 1

Can I translate this to Bangla (Bn)?

Hi @sarequl!

Sure! I would rather prefer Hindi but Bangla is also OK. Please keep in mind what I told you previoulsy.
Many of the strings in both projects are the same, so this will make your work easier (keep in mind that both translations should be consistent).

Thanks so much for your interest!

from ergolux.

Pyr0x1 avatar Pyr0x1 commented on June 18, 2024 1

Hello, I can work on the italian translation if not taken yet

from ergolux.

arthurits avatar arthurits commented on June 18, 2024 1

Hi @Pyr0x1, nobody is working on the Italian translation.

from ergolux.

Xav83 avatar Xav83 commented on June 18, 2024

Hi @arthurits,

I have created a created a Pull Request regarding the french translation (PR #4), and, on my Hacktoberfest profile, this Pull Request has been tagged as NOT-PARTICIPATING.

Screenshot from 2022-10-03 21-51-39

from ergolux.

sarequl avatar sarequl commented on June 18, 2024

Can I translate this to Bangla (Bn)?

from ergolux.

fadkeabhi avatar fadkeabhi commented on June 18, 2024

May I work on hindi translations

from ergolux.

arthurits avatar arthurits commented on June 18, 2024

May I work on hindi translations

Sure @fadkeabhi! I would be very glad if you could! 🙂
Hindi translation is also needed here.

from ergolux.

fadkeabhi avatar fadkeabhi commented on June 18, 2024

May I work on hindi translations

Sure @fadkeabhi! I would be very glad if you could! 🙂 Hindi translation is also needed here.

I am done with hindi translations. and made a PR here arthurits/SignalAnalysis#6 . please approve with hacktoberfest-accepted label.

from ergolux.

Pyr0x1 avatar Pyr0x1 commented on June 18, 2024

One note, the PRs aren't recognized as participating in Hacktoberfest (unless you mark them with the hacktoberfest-accepted label), I think the label linked to the project must be hacktoberfest and not hacktoberfest-2022 to make PRs automatically detected as partecipating.

from ergolux.

arthurits avatar arthurits commented on June 18, 2024

One note, the PRs aren't recognized as participating in Hacktoberfest (unless you mark them with the hacktoberfest-accepted label)

That's true. I believe the idea is that only approved and merged PRs, which are labelled as hacktoberfest-accepted, do participate in Hacktoberfest. But that's not automatic, since maintainers have to validate PRs to check whether they qualify for Hacktoberfest or not. So, unless mistaken, that label is the last step in the process and has to be added by the maintainer.

I think the label linked to the project must be hacktoberfest and not hacktoberfest-2022 to make PRs automatically detected as partecipating.

That's a good point, so I've just added that label at the project level to avoid any unexpected issues. However, after reading the Hacktoberfest validation guide I don't believe there's any automatic detection, unless PRs are merged and labelled as hacktoberfest-accepted.

Please let me know if there's any misunderstanding on my side. Also, don't hesitate to let me know if any of your two contributions (here and here) aren't recognised correctly.

I really appreciate your positive feedback!

from ergolux.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.