artblocks / artblocks-starter-template Goto Github PK

This works great locally. However, I want to deploy it to my Firebase Hosting server and need to build the project.

What script can I run to create a production build of this project?

Would be great if there was an explicit LICENSE file associated with this repo.

For my script to work correctly I need it to be loaded with charset=cp1252 (aka ascii, aka latin1), instead of the currently defined utf8. The script makes use of ascii128-256 to store compressed data as bytes and loading it with utf8 turns all of that into U+fffd replacement character, literally rendering it useless. As I could not find any prior restriction in the on-boarding docs regarding script encoding, I would like to kindly ask for the addition of a custom scriptCharset to support scripts which are not utf8 compatible. e.g change in index.hbs#L38:
<script src="./js/pieces/{{scriptName}}" charset="{{scriptCharset}}"></script>

It took me some time to realize what this loop does or doesn't do :-)

https://github.com/Asupkay/Artblocks-Starter-Template/blob/b06b2e4cde108200596a20b57219f9449fd98044/public/js/example.js#L5

Title:
artist improvement suggestion

Description:
For my first project, writing the features script involved refactoring a bit of my main program pretty late in the dev cycle. I think theres a risk for most projects that this could cause bugs. I think it would be really helpful if the starter-code github project included more of an example of how to manage the feature script, as well as some suggestions on how to calculate them in the main script. Sort of like the provided randomness class AB suggests. That would likely reduce the chances of an artist making a mistake and causing some problems on a released project.

Is this a bug report or a new feature request?:
Feature Request

How urgent is this?:
Low

Importing classes from other js files gives the error Uncaught SyntaxError: Cannot use import statement outside a module