The issue

As it stands at v1.0, there are some significant quantities of code duplication between

• WelcomeTourCellViewModel and AllToursCellViewModel
• WelcomeEventCellViewModel and AllEventsCellViewModel
• WelcomeExhibitionCellViewModel and AllExhibitionsCellViewModel
• AllEventsFragment, AllToursFragment, and AllExhibitionsFragment
• the layout files used by above classes
• the navigation paradigms used by above classes
• the RecyclerView adapters used by the above classes.

This causes no small amount of overhead when editing related visual elements (c.f. PRs #220, #230, #240, #260, #268, #289, etc).

Where it came from

I harbor no ill will towards the existing structure of these elements. Earlier understandings of the desired screens had less commonality and the development team thus took an apprehensive stance towards consolidation. At this stage in the application development process, though, we can be assured that the degree of deviation is much less than then-anticipated.

Resolution plan

By combining the related files into one module, it should be easier to detect inadvertent inconsistencies and share logic to the greatest extent permissible. The new module's name should represent the shared goal of the files aligned with AllEvents, AllExhibitions and AllTours. Name suggestions are welcome, of course, but I will start work with the working title :content_listing for now.

This corresponds to the problems we saw in #358 and #357 , under ticket AIC-646.

Put simply, if we define

<edu.artic.view.DropdownTextView
    android:id="@+id/whatever"
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:visibility="gone"
    />

then RxJava2 calls such as this one sometimes fail to trigger. While we have not been able to calculate a precise incidence rate the Samsung Galaxy S8+ is particularly susceptible. Our current logic inverts the logic (that is, show the views by default and only hide them if derived text is empty), and this seems to work.

@agrosner do you have any thoughts? Perhaps the show binding is being set up too late or disposed of too early?

We disabled the MissingConstraints Lint check a while ago, and just today I merged in #363 to disable NotSibling as well. These sorts of issues can (and do) break the build, so the sooner we ensure compliance the better.

Perhaps updating ConstraintLayout will help? Or can we just make simple fixes to the affected layouts? Feel free to add suggestions.

This codebase has changed a lot since the first commit. @sam33rdhakal and myself will undertake a basic audit, looking for the following things:

• Code we don't understand
• Duplicated code
• Unused code
• Over-complicated code

We'll create PRs for these as we see them, and link them back to this issue. Note that we are not looking to make any significant changes to business logic; if they do get proposed, such changes will be highlighted.

You can follow along with our progress in the branch code_audit; I'm adding comments and questions in the branch pc-identify-codebase-problems-2018.

We can parse the floor out of the gallery directly.
Objects have a gallery location which has floor in it.
Adding floor var with Int.MIN_VALUE might lead to confusion/bug if the floor is not assigned before it is accessed.

We could add the moshi adapter to convert floor string into the int in ArticGallery.
You could use it in ArticGallery.

/**
 * Parses floor as an integer. We default to [Int.MIN_VALUE] as 0 is a valid floor.
 */
class FloorAdapter {

    @ToJson
    fun toText(@Floor floor: Int): String = floor.toString()

    @FromJson
    @Floor
    fun fromText(text: String?): Int {
        return if (text != null) {
            try {
                return text.toInt()
            } catch (e: NumberFormatException) {
                if (text == "LL") {
                    0
                } else {
                    INVALID_FLOOR
                }
            }
        } else {
            INVALID_FLOOR
        }

    }
}

@Retention(AnnotationRetention.RUNTIME)
@JsonQualifier
annotation class Floor
then annotate the floor field in data class

        @Floor @Json(name = "audio_transcript")  val floor: Int

1. BaseAdapterBinder handles conversions.
2. BaseRecyclerViewAdapter needs to be updated to support dropdown view handling to support Spinner dropdown methods. Or decide on utilizing a valid subclass or wrapper implementation.
3. Update @Cliabhach code for LanguageAdapter to use this implementation and update the code to be more RX-like.