arrayhq / atomic-blocks-theme Goto Github PK

PHP Notice: Undefined variable: font_families in /app/public/wp-content/themes/atomic-blocks-theme/functions.php on line 201

The logic in atomic_blocks_fonts_url() assumes $font_families will be defined.

Also, the function always overwrites $fonts_url even when the fonts are disabled.

It should only do that if they fonts haven't been disabled, otherwise it should return the empty string defined at the top of the function.

Here is how related posts show using my old theme, and how I would expect them to show...

However, with the Atomic Blocks theme, it's displaying like this...

Excerpts are displaying instead of the post title. Now show how this can be theme related but I'm not sure how else this is displaying in this way.

I´m single user on my website and i searched everywhere for the meta to disable the author link / or to disable the author display complete. On the other hand i tested different "disable author" plugs, but they are not working too.

Do i miss the code snippet here? Overall a great theme, no doubts.

If you use the Atomic Blocks theme and the Atomic Blocks plugin together, it will load Font Awesome twice.

css handle atomic-blocks-fontawesome - from the plugin
css hanlde font-awesome - from the plugin

It would be great to detect if plugin is used and than load only one version.

We also prepared stripped down version of FA with only few icon (I'm not sure if we covered all necessary icons):
https://github.com/NasWP/naswp-kit-atomic/tree/master/wp-content/themes/naswp-kit-atomic/assets/fonts

When adding an icon to the top, which is quite tall, the menu gets pushed to the top. It would look a lot better centrally aligned.

Here is how it displays now...

The default footer text, Theme by Atomic Blocks, wraps even though there's room to display it.

Screenshot

This doesn't happen when you input custom text. You can have longer text without it wrapping too soon.

Tested in Safari 12.0.2.

The theme could add the &display=swap query argument to improve the performance on the First Meaningful Paint.

https://addyosmani.com/blog/google-fonts-font-display/

I assume simply adding it here would do

https://github.com/ArrayHQ/atomic-blocks-theme/blob/master/functions.php#L170

On my personal blog https://ricard.blog/ I've overwritten the function in my child theme to use display swap and I went from 3 seconds to 1.7 seconds on First Meaningful Paint, giving it 4 extra points to Google PageSpeed Insights.

Could you consider it?

Thank you in advance

Please excuse I am a novice!..
I love this Theme's simplicity and I am trying force myself to use Gutenberg and move away from the 'old school' ...

In the Theme - Customiser - I increased the width of the content area about +30% greater than your Demo to better match my article content.

However, the Gutenberg Editor remains very narrow and does not reflect the 'Preview Mode' result. Even in 'Widescreen Mode' the Gutenberg Editor is very narrow. This is annoying when I am trying to get the layout of Pages/Posts looking nice.

Please help. I would be very, very grateful if I could get my Gutenberg Editor to better reflect what will actually be displayed. I really like this theme and dearly wish to continue to use it. Thanks guys. Andrew.

If you set a custom accent color in the theme, it adds a box shadow to links. This causes the links in the Post Grid block to have an underline and a box shadow. Originally reported here: studiopress/atomic-blocks#81

I'm finding that Gravatars on comments are overlapping. I'm using the Jetpack comment options but not sure if this includes the comment output, or just the adding of new ones.

Here is a screenshot of it...

Thank you for this theme, it's great.

I had some troubles with a alignwide gallery, the transform -50% took the gallery off screen (on a 1440px wide monitor).

Instead of setting a primary wrapper/container with the width, and transforming alignwide/full out of it, why not set the container to be full width, then set the blocks width instead?

Here's some overwriting CSS appended to site that fixed the issue for me:

html #page {
	max-width: 100%;
	padding-left: 0;
	padding-right: 0;
	width: auto;
}
html #primary {
	width: auto;
}
html .entry-content > * {
	margin-left: auto;
	margin-right: auto;
	max-width: 90%;
	width: 780px;
}
html .entry-content > .alignwide {
	max-width: 90%;
	transform: none !important;
	width: 1440px;
}
html .entry-content > .alignfull {
	max-width:100%;
	transform: none !important;
	width: auto;
}

I know this doesn't factor in the "set width" setting in Customizer, this is my use case and just for a code-example.

Again, great theme, thank you so much for making and releasing it.

Hi, I'd like to edit the SCSS partials, but I'm not sure what you use for compilation. I'd be really interested to find out what you use.

Many thanks

When using the Jetpack 'Like' option along with their Share buttons, the Like button appears on the same line, which it shouldn't do. It's using an H3 wrapper.

Here is a screenshot...

I dont know how to describe it nicely.
It would be great if the menu in the header would have the same behaviour as the Latest theme.

Similar to studiopress/atomic-blocks#227, we need to update some styles for things to look as intended.

Similar to that issue, some recurring issues in here like font color/size, icon size, full width alignment.

Here's a first pass at Layouts in this theme.

Editor view

Freelancer
Heading font in editor is wrong color

Latest Posts
Heading color wrong

Mobile App
Heading wrap above video is less than ideal

Heading color wrong on instances with bg images

Font size/spacing looks “off”

Product Launch
Heading fonts wrong color

Professional Services
Icon alignment

Heading font color

Hi,
Here's the issue I reported on wp.org:

This is a continuation of #20, as 1.2.2 has not resolved this issue.

Here is a screenshot from a post I just put together, demonstrating the issue...

I'm suddenly seeing an issue with embedding YouTube videos. When adding a YouTube URL to a post or page and then previewing or publishing and then viewing, there is a large space above the video. At first, the video appears in the correct position and then, after half a second or less, the gap appears.

I've rolled my version of the theme back to 1.1.9 and it's the same - I don't think is an issue with the theme per se, but maybe a change in Gutenberg which has now affected the theme. If I enable another theme the videos appear correctly.

This Gutenberg markup will appear incorrectly...

<!-- wp:core-embed/youtube {"url":"https://www.youtube.com/watch?v=JOm_S5WID4Q","type":"video","providerNameSlug":"youtube","className":"alignwide wp-has-aspect-ratio wp-embed-aspect-16-9"} -->
<figure class="wp-block-embed-youtube wp-block-embed is-type-video is-provider-youtube alignwide wp-has-aspect-ratio wp-embed-aspect-16-9"><div class="wp-block-embed__wrapper">
https://www.youtube.com/watch?v=JOm_S5WID4Q
</div></figure>
<!-- /wp:core-embed/youtube -->

What I couldn't understand is that my past videos are showing correctly, so I checked how GB was showing these and I see the code is a lot simpler...

<!-- wp:core/embed {"url":"https://www.youtube.com/watch?v=JOm_S5WID4Q"} -->
<figure class="wp-block-embed">
    https://www.youtube.com/watch?v=JOm_S5WID4Q
</figure>
<!-- /wp:core/embed -->

My assumption is that this is to do with this theme's classes, as it looks as if Gutenberg may have introduced some new ones that are affecting output.

WordPress 4.9.8
Gutenberg 4.4.0
Theme 1.2.3

When using the Cover block in Gutenberg it seems the theme doesn't have those styles. Or are only printed when I'm logged in.

You can clearly see from the screenshots below how there are missing CSS properties ( example URL https://www.ricardtorres.com/review/horsing-around-red-dead-redemption-2/ )

The HTML generated in the Preview looks like:

<div class="wp-block-cover has-parallax alignfull" style="background-image:url(https://www.ricardtorres.com/wp-content/uploads/2018/11/xRed-Dead-Redemption-2-ps4-2.jpg.pagespeed.ic.BhAx2ORiNO.webp)"></div>

Logged in

Anonymous

Thank you in advance

Hello,

WordPress: 4.9.8
Guttenberg: 4.4.0
Atomic Blocks Theme 1.2.3

I have this blog post https://www.ricardtorres.com/rant/whatsapp-finally-has-stickers/ which when I'm logged in it looks ok (2 columns for images) but if you're logged out you don't see the 2 columns.

Definitely the CSS is different in the different scenarios. Not sure why. Are the styles coming from the Theme or Gutenberg?

Thank you.

Logged in

Logged out

I believe, apologies if I'm wrong, that you've added styling to the Gutenberg editor so that it looks more like the front-end. However, I've used the customizer controls to modify the front-end sizes and now the editor changes make it look less consistent. Can the editor styling be in step with any customizer changes?

We don't need masonry loaded in the theme.

Wondering why there's currently no sidebar template and if you would consider integrating this option. Are there any sidebar related issues with Gutenberg?

breaks the sites pretty well.
there is a dialog "try to restore", but it does nothing.

do you guys have a workaround perhaps?
thanks much

You can improve menu accessibility if you use visually hidden instead of display:none:

@media (max-width: 1000px){
.top-navigation .main-navigation {
display: inline-block;
border-bottom: none;
position: absolute !important;
height: 1px;
width: 1px;
overflow: hidden;
clip: rect(1px, 1px, 1px, 1px);
white-space: nowrap;
}
}

Reference: https://a11yproject.com/posts/how-to-hide-content/

Hi.

I styled some entry with a double page (gutenberg block, page break) feature. I checked the journal front and found this: Double display from "read more" and "page break".

I don't know if this is due to recent editor changes as a result of Gutenberg changes (so may be part of #19) but when adding a list to a block, it appears in, what appears, Times New Roman, rather than the default editor font for the theme.

It would be really nice to have the following tweaks to the current theme...

1. Specify the colour of the header section. I've done it using CSS but a colour-picker, as per the other options, would be a lot better.
2. Rather than have just the text OR a header that's just an image, would it be possible to have a third option - both. So, a graphic can be uploaded and displayed to the left of the text?

Apologies for this but I can't re-open #4.

Even after updating to 1.1.5 this is still occurring - please see https://artiss.blog/2018/04/embedding-code-in-your-wordpress-posts/

atomic-child.zip

When the search-drawer is opened, the class "search-drawer-open" is added to the site-header. But closing the drawer (either with Esc of mouse click) doesn't remove the class.

It would be cool to be able to display the featured images in wide and full width, as per the Gutenberg options. Maybe, a theme specific settings with Customizer, so you can specify how you'd like them.