arquivei / foundationkit Goto Github PK

One of the most recent releases of go added a new way to handle os signals: https://pkg.go.dev/os/signal#NotifyContext

We could refactor the app`s signal handling to use this and possibly simplify the code.

The SetupLogger function could receive a context and return this context with the initialized logger.

If you would like to help out and at the same time get acquainted with the project, please feel free to add more tests and test cases where ever is possible.

MustNew it not using httpClient in:

// MustNew returns a new valid schemaregistry.Repository but panics in case on an error
func MustNew(url string, httpClient *http.Client) schemaregistry.Repository {
	const op = errors.Op("implschemaregistry.MustNew")

	if url == "" {
		panic(errors.E(op, "missing url"))
	}

	if !strings.HasSuffix(url, "/") {
		url += "/"
	}

	return &repository{
		getSchemaByIDURL: url + "schemas/ids/%d",
		getIDBySchemaURL: url + "subjects/%s",
	}
}

https://github.com/arquivei/foundationkit/blob/master/schemaregistry/implschemaregistry/repository.go

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• fix(deps): update all non-major dependencies (cloud.google.com/go/logging, github.com/omeid/uconfig, github.com/prometheus/client_golang, github.com/splitio/go-client/v6, go.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmux, go.opentelemetry.io/otel, go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp, go.opentelemetry.io/otel/sdk, go.opentelemetry.io/otel/trace, golang.org/x/net)

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Allow for multiple individual monitors

Some idea for the future. Create the tye Labes, just like the http has the Values type: https://golang.org/pkg/net/url/#Values

Originally posted by @rjfonseca in https://github.com/_render_node/MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NTYxNTkzMw==/comments/review_comment

When a panic is not handled by the project, the metrics middleware will capture it and logs as panic: panic message here. But we lost the stacktrace and this makes it harder to investigate the problem.

We need a stacktrace in panics logs.

How to capture a stacktrace in recover:
https://stackoverflow.com/questions/52103182/how-to-get-the-stacktrace-of-a-panic-and-store-as-a-variable

Seria interessante uma outra PR adicionando um projetinho de exemplo, talvez em pasta chamada Examples

Originally posted by @eric-reis in #15

I'm using Go 1.19, I cloned the project and ran the command to run the app example:

go run ./app/examples/servefiles/ -log-human -log-level=debug

I got this error:

build github.com/arquivei/foundationkit/app/examples/servefiles: cannot load io/fs: malformed module path "io/fs": missing dot in first path element

I suspected an error with an import, so I ran go mod tidy and got this error:

github.com/arquivei/foundationkit/avroutil/example imports
embed: malformed module path "embed": missing dot in first path element
github.com/arquivei/foundationkit/gokitmiddlewares/metricsmiddleware/v2/example imports
github.com/prometheus/client_golang/prometheus imports
runtime/metrics: malformed module path "runtime/metrics": missing dot in first path element
github.com/arquivei/foundationkit/trace imports
contrib.go.opencensus.io/exporter/stackdriver imports
go.opencensus.io/plugin/ochttp tested by
go.opencensus.io/plugin/ochttp.test imports
golang.org/x/net/http2 imports
io/fs: malformed module path "io/fs": missing dot in first path element

Does anyone know what I may be doing wrong?

In the future we will need to add a .Time() function so we can get the time part from the request-id

Originally posted by @rjfonseca in #18

Add an github action that tests the code.

If you would like to help out and at the same time get acquainted with the project, please feel free update our documentation (using the godoc format) to be more clear and/or add more examples.

A good way to think of it is to ask yourself: Why someone should use this function and write down the answer as a godoc.

https://go.dev/blog/godoc