arpith / tulip Goto Github PK

Since we already have a client build (and this is what is used for dev), going by https://github.com/arpith/rhh/blob/master/.travis.yml and https://github.com/arpith/rhh/blob/master/package.json, it looks like setting up github pages on travis should be straight forward.

This will allow for faster load times and https 😊

Note that this doesn't seem to be as noticeable at 97b7a98

but is noticeable at 5d980ac

Options include using https://bvaughn.github.io/react-virtualized/#/components/List for Users

For example, pm's with lots of people

This breaks the top bar, but also should probably be trimmed / scrollable

Currently the blocker is that graceful-fs and fs-readfile-promise need to be ignored.

In webpack, this was achieved by using externals

According to this links, parcel should support this in package.json / browser
parcel-bundler/parcel#200
https://github.com/defunctzombie/package-browser-field-spec

The other alternative is to ignore the files using babel alias (?!)
parcel-bundler/parcel#144

This code probably doesn't remove duplicates as the members of allUsers are objects.

const allUsers = [].concat(...Object.values(this.reactionsUsers));
const uniqueUsers = new Set(allUsers)
this.setState({ users: Array.from(uniqueUsers) });

Possibly introduced in 97b7a98

The recipients object is an array of users

When UPDATE_MESSAGES is received, any messages that are already stored in the state should be updated.
Specifically, this will allow for handling changed reactions (for instance, when a reaction is incremented).

For example, emojis now have a whitespace after them. I do not think this was the case earlier, but I'm not sure!

Something like https://facebook.github.io/jest/docs/en/snapshot-testing.html might be able to help.

As a nice bonus, some tests will be written finally!

Github pages seems to work - heroku isn't required any more

E.g., pencil and white_frowning_face. These emojis are available in emoji-js. (test: https://unicodey.com/js-emoji/demo/demo.htm)

Since the main purpose of using zulip's mapping data is to handle emoji names that are not converted by emoji-js, perhaps aliases do not need to be added for emoji names that already exist.

The main issue is updating react-router (there are breaking changes between 2 and 4)

Not required any more

This can be seen in the reactions.

Possibilities:

1. The reaction code or my emoji-js wrapper is adding a space
2. Emoji-js is adding a space
3. The code that adds extra emojis
4. Zulip made some change? I feel like this is unlikely since this can be seen for emojis that are being converted by emoji-js from a text name.
5. ???