arjsan1 / classes-arjsan1 Goto Github PK

Java 100.00%

classes-arjsan1's Introduction

Cityscape Lab

# Introduction
# 
The goal of this lab is for you to demonstrate that you can define
	classes, create objects, and display graphics via a Java
	application.

# Requirements
# 
* Commit to GitHub, at least daily, with a meaningful commit message
	describing what you accomplished and what needs to be done next.

* Create a Java graphical application (with a Viewer class, Component
	class, and other classes) that displays a cityscape.

* Complete each milestone and demonstrate to your instructor for
	feedback before continuing to the next milestone.

* **Milestone #1**

    * design one class for an element of the cityscape (e.g.,
	building, window, sun, moon, car, tree)

    * demonstrate good class design (encapsulation)

    * provide configurability through constructors and instance
    	variables (size, color, etc.)

    * demonstrate this milestone to your instructor and receive
    	feedback

* **Milestone #2**

    * create multiple instances of at this class with different
    	properties and display in the cityscape

    * demonstrate this milestone to your instructor and receive
    	feedback

* **Milestone #3**

    * design at least two additional classes, at least three in
    	total, for elements of the cityscape (e.g., building, window,
    	sun, moon, car, tree)

    * demonstrate good class design (encapsulation)

    * provide configurability through constructors and instance
    	variables (size, color, etc.)

    * demonstrate this milestone to your instructor and receive
    	feedback

* **Milestone #4**

    * Animate at least one object in the cityscape. The animation
    	must be purposeful, not random. This means that you must
    	modify a property of an object and that object must persist
    	across calls to the paintComponent method.

    * demonstrate this milestone to your instructor and receive
    	feedback

* Document all classes using JavaDoc comments as demonstrated in our
	[code
	template](https://drive.google.com/file/d/18U-gWhzdb5q6cDMV5up-
	e0itlunQtbrA/view?usp=sharing).

Here is an example design class diagram to illustrate the
	relationship among the classes in this proj![image alt
	text](image_0.png)

# Extensions
# 
* Define additional classes for additional elements of the cityscape.

* Randomize your cityscape (a different cityscape every time)

* Add More Awesome.

# Submission
# 
* Submit a link to your GitHub repository for this assignment in
	Canvas.

* If you would like your Cityscape Lab featured on the school TVs,
	take a short screencast of your animated cityscape and add it to
	the [shared Google slide
	deck](https://docs.google.com/presentation/d/
	1utgoGkeT80Y2CxREjxTef4jxy8t8YyU-UfQOvec37XQ/edit?usp=sharing)
	based on the provided template slide.

https://docs.google.com/document/d/1lXPI4xs0Gn15SQr2bRSXQHGeqDjcgMHxWynYjRQCfKg/edit

classes-arjsan1's People

Contributors

Watchers

classes-arjsan1's Issues

A set method may be useful, but an even more useful method for the purpose of animation would be a move method which updates the position according to instructions provided through parameters.

classes-ArjSan1/UFO.java

Lines 64 to 68 in 42bf570

 public void setX(int xToSet) 

 { 

 this.xLeft = xToSet; 

 }

Javadoc comments are not updated from the template provided.

classes-ArjSan1/CityscapeComponent.java

Line 38 in 42bf570

* @param g2 the graphics context

A better assignment of responsibility for animation would be for the UFO class to encapsulate how its position is changed. Instead of the CityscapeComponent class having to keep track of positions, a single move method could be invoked with instruction on how to move.

classes-ArjSan1/CityscapeComponent.java

Lines 95 to 97 in 42bf570

 if (x <=50) 

 x=500; 

 u1.setX(x=x-50);

I would recommend encapsulating windows within the Building class. The Building class should be responsible for drawing its own windows and then the paintComponent method wouldn't need to handle that. The code would be more reusable, there would be less code in paintComponent, and there would likely be fewer bugs.

classes-ArjSan1/CityscapeComponent.java

Lines 20 to 27 in 42bf570

 private Building b1; 

 private Window w1; 

 private Building b2; 

 private Building b3; 

 private Window w2; 

 private Window w3; 

 private Building b4; 

 private Window w4;

You are inconsistently using the "this" keyword in your class. I suggest using it everywhere an instance variable is referenced, however, if you aren't going to use it you should be consistent and not use it anywhere.

classes-ArjSan1/CityscapeComponent.java

Lines 52 to 54 in 42bf570

 this.u1 = new UFO(550, 200, 200, 30, Color.RED,glass); 

 this.u1 = new UFO(550, 200, 200, 30, Color.RED,glass);

Not necessary to add the type of object in the draw method name since the method will be called on a certain type of object anyway.

classes-ArjSan1/CityscapeComponent.java

Lines 71 to 80 in 42bf570

 this.moon1.drawMoon(g2); 

 this.land1.drawLand(g2); 

 this.b1.drawBuilding(g2); 

 this.w1.drawWindow(g2); 

 this.b2.drawBuilding(g2); 

 this.w2.drawWindow(g2); 

 this.b3.drawBuilding(g2); 

 this.w3.drawWindow(g2); 

 this.b4.drawBuilding(g2); 

 this.w4.drawWindow(g2);

Nice work making your classes configurable and therefor more flexible and reusable!

classes-ArjSan1/CityscapeComponent.java

Lines 42 to 54 in 42bf570

 this.moon1 = new Moon(50,50,50,50, Color.WHITE); 

 this.w1 = new Window(35, 325, 50, 50, Color.YELLOW); 

 this.land1 = new Land(0,500,800,300, Color.GREEN); 

 this.b1 = new Building(25, 300, 100, 200, Color.MAGENTA); 

 this.b2 = new Building(240, 350, 100, 150, Color.CYAN); 

 this.w2 = new Window(290, 370, 35, 30, Color.YELLOW); 

 this.b3 = new Building(470, 325, 100, 175, Color.BLUE); 

 this.w3 = new Window(480, 350, 50, 40, Color.YELLOW); 

 this.b4 = new Building(650, 340,100, 160, Color.PINK); 

 this.w4 = new Window(700, 360, 35, 35, Color.YELLOW); 

 this.u1 = new UFO(550, 200, 200, 30, Color.RED,glass); 

 this.u1 = new UFO(550, 200, 200, 30, Color.RED,glass);

arjsan1 / classes-arjsan1 Goto Github PK

classes-arjsan1's Introduction

classes-arjsan1's People

Contributors

Watchers

classes-arjsan1's Issues

A set method may be useful, but an even more useful method for the purpose of animation would be a move method which updates the position according to instructions provided through parameters.

Javadoc comments are not updated from the template provided.

A better assignment of responsibility for animation would be for the UFO class to encapsulate how its position is changed. Instead of the CityscapeComponent class having to keep track of positions, a single move method could be invoked with instruction on how to move.

You are inconsistently using the "this" keyword in your class. I suggest using it everywhere an instance variable is referenced, however, if you aren't going to use it you should be consistent and not use it anywhere.

Not necessary to add the type of object in the draw method name since the method will be called on a certain type of object anyway.

Nice work making your classes configurable and therefor more flexible and reusable!

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	private Building b1;
	private Window w1;
	private Building b2;
	private Building b3;
	private Window w2;
	private Window w3;
	private Building b4;
	private Window w4;

	this.u1 = new UFO(550, 200, 200, 30, Color.RED,glass);

	this.u1 = new UFO(550, 200, 200, 30, Color.RED,glass);

	this.moon1.drawMoon(g2);
	this.land1.drawLand(g2);
	this.b1.drawBuilding(g2);
	this.w1.drawWindow(g2);
	this.b2.drawBuilding(g2);
	this.w2.drawWindow(g2);
	this.b3.drawBuilding(g2);
	this.w3.drawWindow(g2);
	this.b4.drawBuilding(g2);
	this.w4.drawWindow(g2);

	this.moon1 = new Moon(50,50,50,50, Color.WHITE);
	this.w1 = new Window(35, 325, 50, 50, Color.YELLOW);
	this.land1 = new Land(0,500,800,300, Color.GREEN);
	this.b1 = new Building(25, 300, 100, 200, Color.MAGENTA);
	this.b2 = new Building(240, 350, 100, 150, Color.CYAN);
	this.w2 = new Window(290, 370, 35, 30, Color.YELLOW);
	this.b3 = new Building(470, 325, 100, 175, Color.BLUE);
	this.w3 = new Window(480, 350, 50, 40, Color.YELLOW);
	this.b4 = new Building(650, 340,100, 160, Color.PINK);
	this.w4 = new Window(700, 360, 35, 35, Color.YELLOW);
	this.u1 = new UFO(550, 200, 200, 30, Color.RED,glass);

	this.u1 = new UFO(550, 200, 200, 30, Color.RED,glass);