arjenlammers / csv-connector Goto Github PK

First of all, thanks for creating this module! I was wondering why the "attributes" array is being sorted before writing the line. I tried commenting the line out and was able to preserve the column structure based on the original entity, which would be preferred in my use case. Are there any edge cases I might have missed here?

According to https://docs.oracle.com/javase/tutorial/essential/io/legacy.html nio is preferred over io.

Hi Arjen,

First of all great module with a nice performance.
While implementing I noticed that the description of "ImportCSV" java action is out of date.
The library default quote and escape character in the description do not match the implementation.

My suggestion would be to use the NO_QUOTE_CHARACTER/NO_ESCAPE_CHARACTER, such that this matches passing 'empty' as an argument in the java action.

Kind regards,

Nils

Mx Version: 8.18.14

After installing the module from the app store, I'm seeing the following Java compile errors:
Buildfile: C:\Users\Jounior.Phomma{Application Name}\deployment\build_core.xml

compile:
[javac] Compiling 14 source files to C:\Users\Jounior.Phomma{Application Name}\deployment\run\bin
[javac] C:\Users\Jounior.Phomma{Application Name}\javasource\csv\actions\ExportOQLToCSV.java:35: error: package oql.implementation does not exist
[javac] import oql.implementation.OQL;
[javac] ^
[javac] 1 error

BUILD FAILED
C:\Users\Jounior.Phomma{Application Name}\deployment\build_core.xml:29: Compile failed; see the compiler error output for details.

Total time: 3 seconds

If I remove the module my app loads fine.

I think Export Actions should accept encoding specifications. for now, they cannot be used in encodings other than the default encoding.
And that is actually big problem here Asia, because there is not only one encoding but some encodings in some Asian each countries.
My idea is to add charsetName(encodingName) string parameter to Export action and use it for constructor of FileOutputStream class.
As Is: 'CSVWriter writer = new CSVWriter(new FileWriter(tmpFile), '
To Be: 'CSVWriter writer = new CSVWriter(new BufferedWriter(new OutputStreamWriter(new FileOutputStream(tmpFile), charsetName)),
'
For compatibility, it's a good idea to add a new Action like ExportCSVwithCharset.

I get a compilation error in 9.9.1

\javasource\csv\actions\ExportOQLToCSV.java:35: error: package oql.implementation does not exist [javac] import oql.implementation.OQL; [javac] ^ [javac] ...\javasource\csv\actions\ExportOQLToCSV.java:143: error: cannot find symbol [javac] OQL.resetParameters(); [javac] ^

I have tried CSV output with ExportOQLToCSV and ExportSQLToCSV respectively.
When I try to output Datetime type, I get different numbers for the same data.
When I checked the values, they differed only by the time zone offset of the execution environment.

I think that different data handling in the same module is a source of confusion and should be unified.

Just wondering if Mendix 8 support is on the roadmap?

Currently, attribute of type Datetime are output as numerical timestamps in ExportOQLToCSV and ExportSQLToCSV.
In most cases, the time is displayed as a formatted string rather than a number.
The format also depends on the country where it is used.

I think this is a good thing for the convenience.

I wanted to use the CSV module to import regular expressions, but the read next line action removes all backslashes from the values.

The values are unquoted in my csv file, e.g.
BE;Belgium;^\d{4}$;1234

in the result, the third column is imported as ^d{4}$ which alters the regex expression.

Hi

We are wondering if adding a date format for date fields on export would be good idea going forward. Think currently timestamps get outputted

We could work on a pull request if that is something that would be helpful so you could pass a date format to java actions for exporting CSV's

S

Hi,

the module worked perfectly fine up until my upgrade from Mendix 9.18.4 to 9.24.11. I already upgraded the CSV and the OQL Module to the latest releases, but it still shows me following error:
com.mendix.webui.WebUIException: Attempt to illegally add an object to the state with id '50665495808084976'
at com.mendix.webui.requesthandling.helpers.StateHandling.$anonfun$addObjectsToState$1(StateHandling.scala:133)

Could you please advise?

Cheers
Fulya

Hello,

I wanted to reach out regarding a finding in SonarQube for this project to help determine if this is an actual finding or a false positive. Normally, I would reach out to Mendix Support but this is a Community supported module. Is there a specific way you'd like me to relay the finding for further discussion?

Dear Arjen,

Just upgraded from version 1.8.0 to version 1.9.1 in my Mendix project.

I then need to 'refresh my parameter mapping'.
However, an error on the characterset remains for all my 'Export CSV' actions.
Could you check the specific Export action?

Thanks!

Kind regards,
Mark