Giter Club home page Giter Club logo

Comments (3)

crenshaw-dev avatar crenshaw-dev commented on June 13, 2024

It's a docs issue rather than an actual bug.

The valueFiles path must always be relative to the referenced repo's root.

The path field on a ref source has a completely different purpose: it indicates to Argo CD that the source isn't only for Helm values files but that it should also be used as a source of manifests.

from argo-cd.

OpenGuidou avatar OpenGuidou commented on June 13, 2024

Ok so should we split that in two ?
A doc fix and a feature to handle the Path in the source repo in case it's used for several purposes ?

I would find it weird to accept a path in a repo and not take it into account when using the ref.
It's not so obvious that path should only be read if there are manifest to read from that repo, and it could fit more use cases than that.

from argo-cd.

crenshaw-dev avatar crenshaw-dev commented on June 13, 2024

I think we should change only docs, not the implementation. To change the implementation, we'd either have to make a breaking change or add two modes which increases complexity and (probably) confusion.

from argo-cd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.