Comments (12)
gridley
commented on August 11, 2024
So, what scripts don’t actually run on python 3? I glanced at them and didn’t see any “print ‘asdf’”, etc. I’d totally fix this since it should consist of just some sed commands.
… On Jul 31, 2019, at 5:07 PM, Katy Huff ***@***.***> wrote:
This issue can be closed with either:
a PR that converts Moltres to python3 compatibility (python3.6 or above)
a reason that we can't move forward in time (e.g. .... is the moose framework still using python 2.7?)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
from moltres.
katyhuff
commented on August 11, 2024
Someone told me today there was an issue:
@samgdotson or @robfairh -- I honestly don't recall which one of you was having trouble.
Can you clarify or close?
from moltres.
robfairh
commented on August 11, 2024
I mentioned the thing about the coupling between the velocity and the temperature, but I was mistaken.
If it wasn’t you @samgdotson then you can close the issue.
from moltres.
robfairh
commented on August 11, 2024
I discussed with @samgdotson the issue.
The issue is that run_tests requires python 2 to run. This is something of Moose.
https://groups.google.com/forum/#!topic/moose-users/yLf7otEUksE
Running moltres doesn't have any issues of compatibility.
If I modify the first line of run_tests for:
#!/usr/bin/env python2
then the tests run. This could be an available option to make the tests run and close the issue.
from moltres.
gridley
commented on August 11, 2024
Might just be worth looking into why MOOSE still uses Python 2 (surprising!). It’s usually just the different print statement format that causes incompatibility in my experience.
Gavin Ridley
… On Aug 1, 2019, at 11:07 AM, robfairh ***@***.***> wrote:
I discussed with @samgdotson the issue.
The issue is that run_tests requires python 2 to run. This is something of Moose.
https://groups.google.com/forum/#!topic/moose-users/yLf7otEUksE
Running moltres doesn't have any issues of compatibility.
If I modify the first line of run_tests for:
#!/usr/bin/env python2
then the tests run. This could be an available option to make the tests run and close the issue.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
from moltres.
robfairh
commented on August 11, 2024
Yes, run_tests relies on files like this one:
https://github.com/idaholab/moose/blob/master/python/FactorySystem/Factory.py
where all the print statements have the python 2 format.
What should we do about this issue then? @katyhuff
from moltres.
gridley
commented on August 11, 2024
Why not just find and replace to Python 3 print statements and submit a PR
to MOOSE?
…On Thu, Aug 1, 2019 at 12:32 PM robfairh ***@***.***> wrote:
Yes, run_tests relies on files like this one:
https://github.com/idaholab/moose/blob/master/python/FactorySystem/Factory.py
where all the print statements have the python 2 format.
What should we do about this issue then? @katyhuff
<https://github.com/katyhuff>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#95?email_source=notifications&email_token=AEKAHSW7YQMP2UCOFONUUTTQCMFY7A5CNFSM4IIKSKSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3LFKZI#issuecomment-517363045>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEKAHSXL4JI34OQ6YK63NS3QCMFY7ANCNFSM4IIKSKSA>
.
--
Thanks,
Gavin Ridley
from moltres.
robfairh
commented on August 11, 2024
We would have to check if that works, I don't know if it is just the print statements or not.
According to this, there are more things that use python 2: the RHEL cluster systems.
https://groups.google.com/d/msg/moose-users/yLf7otEUksE/l2SmgydaBwAJ
from moltres.
gridley
commented on August 11, 2024
Hm, well, if they’ve not changed it yet, maybe we should prod them to do it. Not that it matters that much at the moment, aside from being an annoyance.
Gavin Ridley
… On Aug 1, 2019, at 1:59 PM, robfairh ***@***.***> wrote:
We would have to check if that works, I don't know if it is just the print statements or not.
According to this, there are more things that use python 2: the RHEL cluster systems.
https://groups.google.com/d/msg/moose-users/yLf7otEUksE/l2SmgydaBwAJ
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
from moltres.
smpark7
commented on August 11, 2024
The MOOSE team are updating all python code in MOOSE to python3.7 by October 28
https://groups.google.com/forum/?pli=1#!topic/moose-users/iMTWElMYuRQ
from moltres.
smpark7
commented on August 11, 2024
I believe this can be closed as the run_tests script is now compatible with python3. I'll close this issue if no one disagrees
from moltres.
katyhuff
commented on August 11, 2024
(no need to wait... just close an issue when you feel it's ready..)
from moltres.
Related Issues (20)
- Replace the Nt action with a more intuitive name
- Tutorial issues
- Add additional installation instructions HOT 1
- Remove deprecated MOOSE code HOT 7
- moltres_xs.py maybe not compatiable with the newest version of OpenMC
- Removing unused params
- Replace deprecated NodalMaxValue
- Fix removal cross section generation in moltres_xs.py from OpenMC data
- where is the k-eff definition? HOT 1
- Add postprocessor for calculating neutron leakage
- CIVET: 'Mirror scheduled' failure
- Make PrecursorAction compatible with velocity vector variables derived from INSAD
- Welcome to Moltres Discussions! HOT 8
- Create a CI test for building documentation HOT 1
- Rename convoluted object names for clarity
- Extend PrecursorAction to support modeling with higher order precursor variables
- Add documentation on neutron diffusion theory on the Moltres website
- Compilation issue on MacOS with clang HOT 2
- Add override keyword to computeQpOffDiagJacobian in INSBoussinesqBodyForce
- Allow users to choose among Marshak, Mark, and Milne vacuum boundary conditions
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from moltres.