Giter Club home page Giter Club logo

Comments (7)

smpark7 avatar smpark7 commented on August 11, 2024 1

Oh I initially misunderstood you but I get what you mean now. Thanks for clarifying!

from moltres.

smpark7 avatar smpark7 commented on August 11, 2024 1

Thanks for the update. We'll track the eventual transition to Eigenvalue with #177.

from moltres.

smpark7 avatar smpark7 commented on August 11, 2024

Thanks for the heads up! The p parameter is easy enough to replace. The transition to Eigenvalue executioner will require more manhours because we'd have to change our Action files.

On your last point, would we have to manually turn on "Test deprecated" in every PR?

from moltres.

cticenhour avatar cticenhour commented on August 11, 2024

On the CIVET user interface, if you have sufficient permissions, you can turn on tests that don't normally run on PRs. For example I am also a maintainer of Zapdos, so if I look at an open PR, I can also see the option to turn on the deprecated test that would only otherwise run on the master branch:
image
Do you see this when looking at an open PR results page on CIVET for Moltres? I could check and then submit "Test deprecated" as an add-on for that Zapdos PR above.

from moltres.

cticenhour avatar cticenhour commented on August 11, 2024

I would only add this for the PR you submit to close this.....you don't necessarily want it running all the time, just when you're trying to clean up what is currently being flagged.

from moltres.

smpark7 avatar smpark7 commented on August 11, 2024

@cticenhour Is InversePowerMethod no longer deprecated? I noticed that the CIVET deprecation tests are passing, and there are some open issues about the new Eigenvalue executioner (e.g., idaholab/moose#20095)

from moltres.

cticenhour avatar cticenhour commented on August 11, 2024

You are correct. There seems to be some issues regarding the new executioner, so InversePowerMethod is no longer deprecated for the moment. If you have fixed up everything else, I would say this issue can be closed.

from moltres.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.